Init another class in construct method?

Question

I am looking into trying to simplify my PHP code some more, and I have yet to find an answer with this methodology one of my team members are using. Nor, have I ever saw this done before anywhere on the web.

Here is the code example from our web application which he is working on with me.

<?php class ArticlesHandler { public function __construct() { require 'Articles.php'; $articles = new Articles; } } ?>

Is this proper to init one class within another class?

For me, this just seems not proper standard to init classes to work together.

deceze · Accepted Answer · 2014-05-02 09:58:33Z

Yes and no. It works, but this particular code can lead to a number of problems.

You should be using require_once instead of require to avoid possible errors of including the same file twice. As it is this code here will bring your app to a complete stop:
```
new ArticlesHandler; new ArticlesHandler; 
```
This creates a hard coupling to the Articles class. You should probably rather be using dependency injection and pass an instance of Article to the constructor of ArticlesHandler. See How Not To Kill Your Testability Using Statics.

lejlot · Accepted Answer · 2014-05-02 09:53:30Z

Yes, it is proper and normal to call constructors in a constructor. There is nothing weird/bad about it.

Jay Bhatt · Accepted Answer · 2014-05-02 10:39:50Z

This is what I normally do.

class Repository { protected $_models = array(); public function getModel($model, array $params = array()){ require_once $model.'.php'; //Replace this with an autoloader if(empty($this->_models[$model])){ if(!empty($params)){ $this->_models[$model] = new $model($params); } else { $this->_models[$model] = new $model(); } } return $this->_models[$model]; } }

And call the other class like this.

 class ArticlesHandler extends Repository { public function __construct() { $articles = $this->getModel('Articles'); } }

syntax error: if(empty($this->_models[$model)){ should be: if(empty($this->_models[$model])){. Can't edit your post, though :(
You're requireing the file after you instantiate the class...?!
@deceze Oops. Another mistake. Thanks for pointing out. I have corrected this.

ashishmaurya · Accepted Answer · 2014-05-02 09:56:57Z

it seem's right.
For me, this just seems not proper standard to init classes to work together.

you can extend Articles class if you want to use Articles class inside the ArticlesHandler

Collectives™ on Stack Overflow

Init another class in construct method?

4 Answers 4

Comments

Comments

3 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

3 Comments

Comments

Related