Concatenate strings in bash

Question

I have in a bash script:

for i in `seq 1 10` do read AA BB CC <<< $(cat file1 | grep DATA) echo ${i} echo ${CC} SORT=${CC}${i} echo ${SORT} done

so "i" is a integer, and CC is a string like "TODAY"

I would like to get then in SORT, "TODAY1", etc

But I get "1ODAY", "2ODAY" and so

Where is the error?

Thanks

The command for i in `seq 1 10` ; do echo HELLO$i ; done gives HELLO1 HELLO2 ... The problem may be in file1 — mouviciel
– mouviciel, Commented Mar 4, 2010 at 13:28
show an example of your contents of your input file1, and your desired output. — ghostdog74
– ghostdog74, Commented Mar 4, 2010 at 13:30

tonio · Accepted Answer · 2010-03-04 13:33:07Z

7

You should try

SORT="${CC}${i}"

Make sure your file does not contain "\r" that would end just in the end of $CC. This could well explain why you get "1ODAY".

Try including |tr '\r' '' after the cat command

answered Mar 4, 2010 at 13:28

10.6k2 gold badges51 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

your files may have \r\n lien ending, and read understands only the \n. So the \r ends in the CC variable...you should remove it.

+1 Had a related problem reading a curl header into a variable

ghostdog74 · Accepted Answer · 2010-03-04 13:32:10Z

try

 for i in {1..10} do while read -r line do case "$line" in *DATA* ) set -- $line CC=$3 SORT=${CC}${i} echo ${SORT} esac done <"file1" done

Otherwise, show an example of file1 and your desired output

Charles Stewart · Accepted Answer · 2010-03-04 20:48:21Z

ghostdog is right: with the -r option, read avoids succumbing to potential horrors, like CRLFs. Using arrays makes the -r option more pleasant:

 for i in `seq 1 10` do read -ra line <<< $(cat file1 | grep DATA) CC="${line[3]}" echo ${i} echo ${CC} SORT=${CC}${i} echo ${SORT} done