How to extract exception error to property?

Question

How do I extract the exception from the error into the propery status? This doesn't work:

public class MyClass{ public string status { get; set; } public string MyAction() { try { ... status = "OK"; return status; } catch (Exception ex) { //throw ex; status = ex; } } }

You can't assign Exception to a string... Did you mean to do status = ex.Message? — siva.k
– siva.k, Commented Aug 24, 2014 at 4:48
Don't you see...ex is a variable of type Exception, and status is a string? status = ex.ToString(); is what technically does what you're looking for, but I won't say this is a good exception handling design... — kevin
– kevin, Commented Aug 24, 2014 at 4:49
You should catch the specific types of exceptions happening, and create an enumeration for them so you could have properties like ErrorType and ErrorMessage. With ErrorType.Success being 0 in the enumeration. Or something like that. Using a string to drive a status in c# is a really bad design. Enumerations are much more reliable and easier to work with. Also, ToString on an enumeration will spit out the values name. And you can use Enum.Parse to parse a name into it's enumeration value. — Ryan Mann
– Ryan Mann, Commented Aug 24, 2014 at 4:59
What are you trying to accomplish here? If you can't handle an exception, don't catch it. — Daniel Mann
– Daniel Mann, Commented Aug 24, 2014 at 5:26

Control Freak · Accepted Answer · 2014-08-24 04:59:32Z

1

Right now you're assigning the Exception object to the status variable. You need to use the actual message property of the Exception like so:

status = ex.Message; return status;

edited Aug 24, 2014 at 4:59

Control Freak

13.2k31 gold badges101 silver badges150 bronze badges

answered Aug 24, 2014 at 4:48

Logarr

2,6291 gold badge22 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Control Freak Over a year ago

So you're saying all I have to do is change the current code in catch to what you have and it should all work?

Control Freak Over a year ago

I did, and it doesn't work. If I change it back to throw ex; it works, and returns the error.

Control Freak Over a year ago

It gives this error on MyAction() in the debugger: not all code paths return a value

Logarr Over a year ago

Because your method isn't returning a value if you're just setting a variable. You should either return status after you give it a value, or return a generic error message.

Logarr Over a year ago

Well really if all you're doing is returning status (bad idea in my opinion) then you don't even need the variable. You can just do return ex.Message;.

score 0 · Accepted Answer · 2014-08-24 05:24:37Z

0

i think this will work

 public class MyClass { public string status { get; set; } public string MyAction() { try { return status = "OK"; } catch (Exception ex) { //throw ex; return status = ex.Message.ToString(); } } }

edited Aug 24, 2014 at 5:24

answered Aug 24, 2014 at 5:10

user3967508

2 Comments

Logarr Over a year ago

Two problems. 1 - Not all exceptions have an inner exception. 2 - This will not return the message of either exception.

user3967508 Over a year ago

@logarr i just show the demo he can change that to message now is it clear

Collectives™ on Stack Overflow

How to extract exception error to property?

2 Answers 2

5 Comments

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

2 Comments

Related