Erasing an element from a vector within a for loop - C++

Question

I'm trying to erase an enemies' health value when they are destroyed and I get the error "No instance of overloaded function "..." matches the argument list if I have the following:

upgradeHealth.erase(inner)

It seems to only accept something like this:

upgradeHealth.erase(upgradeHealth.begin())

I need the element at position inner to be erased so that it matches the enemy that just got destroyed. Here's the for loop:

for (outer = 0; outer < bullets.size(); outer++) { for (inner = 0; inner < upgrades.size(); inner++) { if (upgrades[inner]->HitTest(bullets[outer])) { upgradeHealth[inner] -= 1; bullets.erase(outer--); multiplier += 0.01; hasHit = true; multiplierTime = 0; cout << upgradeHealth[inner] << endl; if (upgradeHealth[inner] == 0) upgradeHealth.erase(inner), upgrades.erase(inner), score += 100 * multiplier; break; } } }

I had considered doing that but glossed over it, however it works so thank you! — StallMar
– StallMar, Commented Dec 4, 2014 at 15:15

Vlad from Moscow · Accepted Answer · 2014-12-04 15:05:03Z

There are only two overloaded member functions erase in class std::vector

iterator erase(iterator position); iterator erase(iterator first, iterator last);

Community · Accepted Answer · 2017-05-23 11:50:55Z

You can only erase an iterator using the erase(...) methods of the std::vector.

You can check this answer for how to get an iterator from an index. Although I would suggest you rethink your algorithm so that you don't need such a conversion.

Collectives™ on Stack Overflow

Erasing an element from a vector within a for loop - C++

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related