JSF button action triggered twice

Question

I already asked this question in the WildFly forum but did not get any answers so far. So I´m trying here.

Since I upgraded from WildFly 8.1 to 8.2 I have problems with a commandButton inside a tabView connected to a bean.

Here is a simple JSF page:

<?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE html> <html xmlns="http://www.w3.org/1999/xhtml" xmlns:h="http://xmlns.jcp.org/jsf/html" xmlns:p="http://primefaces.org/ui"> <h:head></h:head> <h:body> <h:form> <p:tabView binding="#{testBean.tabView}"> <p:tab title="Tab"> <p:commandButton value="Inside" action="#{testBean.testInside}"/> </p:tab> </p:tabView> <p:commandButton value="Outside" action="#{testBean.testOutside}"/> </h:form> </h:body> </html>

and the bean:

@Named @SessionScoped public class TestBean implements Serializable { private TabView tabView = new TabView(); public TabView getTabView() { return tabView; } public void setTabView(TabView tabView) { this.tabView = tabView; } public void testInside() { System.out.println("inside"); } public void testOutside() { System.out.println("outside"); } }

Clicking the "Inside" button triggers testInside() two times. The "Outside" button (outside of the tabView) behaves normally and triggers it´s method only once. Removing the tabView binding eliminates the problem. I´m using PrimeFaces 4.0.

Thanks for any ideas

Jan

Why is the binding (binding="#{testBean.tabView}") needed at all? — Tiny
– Tiny, Commented Feb 2, 2015 at 8:38
The binding is needed in the real application because the tabs are generated dynamically. — jpstrube
– jpstrube, Commented Feb 2, 2015 at 8:57
Can you try this minimal application with a newer PF version and check if it still happens? — Kukeltje
– Kukeltje, Commented Feb 2, 2015 at 11:33
@BalusC you said "Components are request scoped, yet you're binding it to a session scoped bean", does that mean that we should always use binding with request scoped beans.? — Tarik
– Tarik, Commented Feb 2, 2015 at 13:07
I think that i found some answers here in SO, that may also help the OP (attached links in BalusC answer are also very useful): stackoverflow.com/questions/18667927/… — Tarik
– Tarik, Commented Feb 2, 2015 at 13:12

Community · Accepted Answer · 2020-06-20 09:12:55Z

It's a Mojarra 'issue', introduced by a performance optimization fix in 2.2.7.

this is a Mojarra "issue", I've discovered it when working on RF-13920, it was introduced by JAVASERVERFACES-3193. The components that use binding are not recreated during a request to the server but their children are. With the original children still in place inserting the new children causes the "duplicate id" error.

So it looks like your button is added twice, but since you do not have an explicit id assigned, you do not get the duplicate id error... Might be interesting to give that a try (adding an explicit id)

The JSF specification states that binding should only be used in Request scope, so I don't think it should be treated as a bug if this fails in Conversation scope.

The last remark is the interesting one. As is posted in the next post on the jboss site:

But now I think I have a satisfying solution for this issue and I can confirm, that with request-scoped backing beans for the component binding the exception and duplicate id problem does not occur anymore, even with Mojarra 2.2.8 from Wildfly-8.2.0.Final!

This is even true if the rest of the logic for the page remains in a (say) conversation scoped bean. You just need to have a request-scoped bean for the binding attribute, which then can be referenced in EL and other beans.

Check also this post

You are right, Assigning an id results in the duplicate id error. I will try to get along with Request scope or abandon the binding as BalusC suggested.
yes unfortunately , I couldn't afford to refactor the code, downgrading seems working some how, though i am facing troubles with binding backbean of ViewScope
Bad choice... Bite the Apple and refactor... Always the netter choice. Especially since now you run into different issues @ameen
you are right - but it is a lot and the task is time limited and already violated

Bhargav Rao · Accepted Answer · 2016-11-29 20:35:59Z

You can try doing in other way. Use remoteCommand out of the tab with the same action of the commandButton.
Then use the JavaScript function created by the remoteCommand in the onclick event of the commandButton.
Here is the example using your code.
It's functional.

<h:form> <p:remoteCommand id="myfun" name="myfun" action="#{testBean.testInside}" /> <p:tabView binding="#{testBean.tabView}"> <p:tab title="Tab"> <p:commandButton value="Inside" onclick="myfun();"/> </p:tab> </p:tabView> </h:form>

Sure, but if you have 6 tabs, with 6 different buttons you need 6 remote commands. And using a commandButton in this case is also 'wrong', you should use a commandButton with type="button"... This solution is introducing more complexity then needed by doing it 'right'

Collectives™ on Stack Overflow

JSF button action triggered twice

2 Answers 2

5 Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

1 Comment

Linked

Related