A single exception handler for multiple possible exceptions

Question

I would like to check the results from a C# database call to make sure ..

The DataTable returned is NOT NULL
The DataTable has rows (DataTable.Rows.Count > 1)

If either of these conditions are true I want to return the same exception as this type of result is not expected, there should always some records. Is there a way to do this without repeating the throw exception statement?

if (myDataTable != null) { if (myDataTable.Rows.Count > 0) { myRow = myDataTable.Rows[0]; } else { throw new Exception("Problem obtaining data"); } } else { throw new Exception("Problem obtaining data"); }

I don't need to differentiate between these exceptions for my purposes.

David Arno · Accepted Answer · 2015-06-05 15:35:35Z

4

Maybe

if (myDataTable != null && myDataTable.Rows.Count > 0) { myRow = myDataTable.Rows[0]; } else { throw new Exception("Problem obtaining data"); }

You don't need to nest the if statements

edited Jun 5, 2015 at 15:35

David Arno

43.4k16 gold badges89 silver badges132 bronze badges

answered Jun 5, 2015 at 15:33

pollirrata

5,2942 gold badges35 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Panagiotis Kanavos Over a year ago

In C# 6 you could write if (myDataTable?.Rows.Count >0) and avoid the null check

webworm Over a year ago

Marked as answer because I like the idea of having the exception in the else. Answer from @sebastien was also correct. Sorry.. had to choose one.

jadhachem Over a year ago

It might be worth adding a small explanation about short-circuit evaluation of && and || for those who are unfamiliar with it.

Sébastien Sevrin · Accepted Answer · 2015-06-05 15:34:52Z

3

You could simply write:

if (myDataTable == null || myDataTable.Rows.Count == 0) { throw new Exception("Problem obtaining data"); } myRow = myDataTable.Rows[0];

edited Jun 5, 2015 at 15:34

answered Jun 5, 2015 at 15:33

Sébastien Sevrin

5,4132 gold badges25 silver badges42 bronze badges

1 Comment

pollirrata Over a year ago

I think the null check is inverted :)

Collectives™ on Stack Overflow

A single exception handler for multiple possible exceptions

2 Answers 2

3 Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Related