Calculating sum of ascii values of a char

Question

I need to create a hash function that is supposed to return the sum of the ASCII values mod by 100(which is HASH_TABLE_SIZE) in a given char, but I don't seem to be getting the correct output. How do I correct this?

int string_set::hash_function(const char *s) { int h = 0; for (int i =0; i < *s; i++) { h = h + int(s[i]); return h % HASH_TABLE_SIZE; } return h; }

for example hash_function("a") should return 97 , and hash_function("ab") would return 95 — ProgrammingNoob
– ProgrammingNoob, Commented Sep 28, 2015 at 3:33
i < *s is supposed to be such that i is less than the length of the char *s — ProgrammingNoob
– ProgrammingNoob, Commented Sep 28, 2015 at 3:35

Jarod42 · Accepted Answer · 2015-09-28 07:33:43Z

Do not return in the middle of process.

Try this:

int string_set::hash_function(const char *s) { int h = 0; for (int i =0; s[i] != '\0'; i++) // the loop condition didn't seem good { // the cast to unsigned char may be needed for system in which the type char is signed h = (h + (unsigned char)s[i]) % HASH_TABLE_SIZE; } return h; }

This code will work well only if your system use ASCII code as character code for char.

The int cast is redundant, integer promotions makes that same conversion anyway

Collectives™ on Stack Overflow

Calculating sum of ascii values of a char

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related