16

I have looked at the answers here - Android Preventing Double Click On A Button and implemented qezt's solution like and I've tried setEnabled(false) like so - 

doneButton.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { // mis-clicking prevention, using threshold of 1 second if (SystemClock.elapsedRealtime() - doneButtonClickTime < 1000){ return; } //store time of button click doneButtonClickTime = SystemClock.elapsedRealtime(); doneButton.setEnabled(false); //do actual work } });

Neither of these work against super fast double clicks.

Note - I'm not setting doneButton.setEnabled(true) after my processing is done. I simply finish() the activity so there is no issue of the button getting enabled too soon.

Improve this question
11
  • 1
    why wasn't setEnabled(false) working ? Commented Sep 28, 2015 at 9:20
  • where you apply setEnabled(false);? Commented Sep 28, 2015 at 9:21
  • you can give it in onclick event Commented Sep 28, 2015 at 9:21
  • 1
    @Blackbelt this comment seems to answer why. Commented Sep 28, 2015 at 9:39
  • 1
    @Blackbelt it won't work. Please see the comment I linked to in my first comment. Commented Sep 28, 2015 at 11:14

11 Answers 11

Reset to default
21

I am doing like this it works very well.

public abstract class OnOneOffClickListener implements View.OnClickListener { private static final long MIN_CLICK_INTERVAL=600; private long mLastClickTime; public static boolean isViewClicked = false; public abstract void onSingleClick(View v); @Override public final void onClick(View v) { long currentClickTime=SystemClock.uptimeMillis(); long elapsedTime=currentClickTime-mLastClickTime; mLastClickTime=currentClickTime; if(elapsedTime<=MIN_CLICK_INTERVAL) return; if(!isViewClicked){ isViewClicked = true; startTimer(); } else { return; } onSingleClick(v); } /** * This method delays simultaneous touch events of multiple views. */ private void startTimer() { Handler handler = new Handler(); handler.postDelayed(new Runnable() { @Override public void run() { isViewClicked = false; } }, 600); } }
Improve this answer
Sign up to request clarification or add additional context in comments.

1 Comment

I pressume it needs to be implemented on a single class instance then set the click on all the desired views
8

I use a function like this in the listener of a button:

public static long lastClickTime = 0; public static final long DOUBLE_CLICK_TIME_DELTA = 500; public static boolean isDoubleClick(){ long clickTime = System.currentTimeMillis(); if(clickTime - lastClickTime < DOUBLE_CLICK_TIME_DELTA){ lastClickTime = clickTime; return true; } lastClickTime = clickTime; return false; }
Improve this answer

1 Comment

This worked for me after reversing the return booleans. I have edited the answer.
3

Probably not most efficient, but minimal inversive:

... onClick(View v) { MultiClickPreventer.preventMultiClick(v); //your op here } ... public class MultiClickPreventer { private static final long DELAY_IN_MS = 500; public static void preventMultiClick(final View view) { if (!view.isClickable()) { return; } view.setClickable(false); view.postDelayed(new Runnable() { @Override public void run() { view.setClickable(true); } }, DELAY_IN_MS); } }
Improve this answer

Comments

3

You can use this method. By using post delay you can take care for double click events.

void debounceEffectForClick(View view) {

view.setClickable(false); view.postDelayed(new Runnable() { @Override public void run() { view.setClickable(true); } }, 500);

}

Improve this answer

Comments

1

Suru's answer worked well for me, thanks!

I'd like to add the following answer for anybody who's using https://github.com/balysv/material-ripple/blob/master/library/src/main/java/com/balysv/materialripple/MaterialRippleLayout.java and is facing this problem -

app:mrl_rippleDelayClick is true by default. This means, onClick will be executed only after it's finished showing the ripple. Hence setEnabled(false)inside onClick will be executed after a delay because the ripple isn't done executing and in that period you may double click the view.

Set app:mrl_rippleDelayClick="false" to fix this. This means the call to onClick will happen as soon as the view is clicked, instead of waiting for the ripple to finish showing.

Improve this answer

2 Comments

It's more of a comment than an answer
It was better decision to post your answer than a comment. Because i had the same problem with MaterialRippleLayout and i found separate solution for that. Thanks @Mallika.
1 
private static final long MIN_CLICK_INTERVAL = 1000; private boolean isViewClicked = false; private View.OnClickListener onClickListener = new View.OnClickListener() { @Override final public void onClick(View view) { if (isViewClicked) { return: } // place your onClick logic here isViewClicked = true; view.postDelayed(new Runnable() { @Override public void run() { isViewClicked = false; } }, MIN_CLICK_INTERVAL); }

}

Improve this answer

Comments

0

try to set yourbutton.setClickable(false) like this : 

onclick(){ yourbutton.setClickable(false) ; ButtonLogic(); } ButtonLogic(){ //your button logic yourbutton.setClickable(true); }
Improve this answer

2 Comments

Hey, I've tried this but the button is still clickable if I press it in quick succession. I guess disabling the button or setting unclickable is not enough if you are doing computationally intensive work in onClick() since click events can get queued up before the button can be disabled. Any ideas?
I usually use a progress dialog to prevent the user from interacting with UI if necessary . you may want to try it if the process you are doing takes longer than you wish .
0 
public static void disablefor1sec(final View v) { try { v.setEnabled(false); v.setAlpha((float) 0.5); v.postDelayed(new Runnable() { @Override public void run() { try { v.setEnabled(true); v.setAlpha((float) 1.0); } catch (Exception e) { Log.d("disablefor1sec", " Exception while un hiding the view : " + e.getMessage()); } } }, 1000); } catch (Exception e) { Log.d("disablefor1sec", " Exception while hiding the view : " + e.getMessage()); } }

I kept above method in a static file and i will call this method for all the buttonclick like this

 button_or_textview.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { StaticFile.disablefor1sec(button_or_textview); // Do Somthing. } });
Improve this answer

Comments

0

Qezt solution is already fine. But if you want to prevent super fast double-click, then you simply reduce the threshhold

 // half a second if (SystemClock.elapsedRealtime() - doneButtonClickTime < 500) { return; } // or 100ms (1/10 of second) if (SystemClock.elapsedRealtime() - doneButtonClickTime < 100) { return; }
Improve this answer

Comments

0

Set the launchMode of the activity in manifest as singleTop

 <activity android:name="com.example.MainActivity" android:screenOrientation="portrait" android:launchMode="singleTop"/>
Improve this answer

1 Comment

The question has nothing to do with launching activities
0

Kotlin short version:

private var lastClickTime: Long = 0 //in click listener if (SystemClock.elapsedRealtime() - lastClickTime < 1000) { return@setOnClickListener } lastClickTime = SystemClock.elapsedRealtime()
Improve this answer

Comments

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.