Parsing csv with c

Question

I have the following to parse a csv file, and it works fine until i changed

(getfield(tmp, 12));

to

(getfield(tmp, ver));

Is the problem in function declaration ?

here is the code :

const char* getfield(char* line, int num) { const char* tok; for (tok = strtok(line, ";"); tok && *tok; tok = strtok(NULL, ";\n")) { if (!--num) return tok; } return NULL; } int main() { double frame_index[40][300]; int horz; FILE* fp = fopen("output.txt", "r"); char line[1024]; for (int ver; ver<20;ver++) { while (fgets(line, 1024, fp)) { char* tmp = strdup(line); frame_index[ver][horz] = atof(getfield(tmp, ver)); // works if "ver" was explicitly defined printf("AA %f\n", frame_index[ver][horz]); free(tmp); horz++; } rewind(fp); } }

getfield() may return NULL. Need to test for that before calling atof(). — chux
– chux, Commented Mar 16, 2016 at 14:06

Eugene Sh. · Accepted Answer · 2016-03-16 13:43:10Z

2

You never initialize the variable ver. For example you might want to change

for (int ver; ver<20;ver++)

to

for (int ver=0; ver<20;ver++)

Update The same with horz..

edited Mar 16, 2016 at 13:43

answered Mar 16, 2016 at 13:37

Eugene Sh.

18.7k8 gold badges45 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

night hunter Over a year ago

still getting a segfault :(

night hunter Over a year ago

shouldn't be initialization automatically ?

Eugene Sh. Over a year ago

For automatic (local) variables? No.

night hunter Over a year ago

tried initializing the variables to zero, no avail thou.

Eugene Sh. Over a year ago

Then you have additional problems. For example you never check your file has no more than 300 lines. Also you don't check each line is correct format. You should add some error-handling. And I would avoid composite constructs negation/predecrement and the token manipulation inside the for statement.

|

Collectives™ on Stack Overflow

Parsing csv with c

1 Answer 1

6 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Linked

Related