Duplicated block of Code in Sonar for import statements in Java

Question

In Sonar 4.5.6 (with default settings) I am seeing Duplicated Blocks message as

My java code for which I am getting the message is like below:-

package com.jabong.orchestratorservice.adapter.order.endpoints; import com.jabong.orchestratorservice.adapter.order.request.UpdateOrderStatusReadyShipRequest; public class UpdateOrderReadyShipEndPoint extends BaseOrderEndPoint { private final static String API_NAME = "setStatusToReadyToShip"; @Override public String getSourceEndPoint() { return new StringBuilder("direct:").append(API_NAME).toString(); } @Override public String getDestinationEndPoint() { return new StringBuilder("bean:orderHelper?method=").append(API_NAME).toString(); } @Override protected String getName() { return API_NAME; } @Override protected String getApiInputClassName() { return UpdateOrderStatusReadyShipRequest.class.getName(); } }

UpdateOrderStatusReadyShipRequest also does not import UpdateOrderReadyShipEndPoint

package com.jabong.orchestratorservice.adapter.order.request; public class UpdateOrderStatusReadyShipRequest extends BaseOrderRequest {

Can some let me know what does this mean?

Does the other class import this one?

Tom
– Tom

2016-03-20 09:06:33 +00:00
Commented Mar 20, 2016 at 9:06 — Tom
– Tom, Commented Mar 20, 2016 at 9:06
No it does not import.

tuk
– tuk

2016-03-20 09:09:41 +00:00
Commented Mar 20, 2016 at 9:09 — tuk
– tuk, Commented Mar 20, 2016 at 9:09

eddex · Accepted Answer · 2019-02-25 08:58:25Z

38

The Duplicate Blocks rule raises issues at the file level. So it's not trying to tell you that your import statement is duplicated, but that somewhere in the file is a duplicate block. If you'll scroll down, you should see a vertical yellow/orange bar in the left margin. It marks the duplicate block. Click on the bar to get details of where the block is duplicated.

EDIT In more recent versions the duplication marker is brown or gray.

edited Feb 25, 2019 at 8:58

eddex

2,2722 gold badges22 silver badges45 bronze badges

answered Mar 21, 2016 at 12:22

G. Ann - SonarSource Team

23k4 gold badges48 silver badges93 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Tolgahan Albayrak Over a year ago

I had same issue on my project. Abstract class implemented with two other classes with same overrides. Sonar issued this as same block. But actually it was not. Anyway I get rid of it by replacing method order in one of that classes. Funny, isn't it? :)

beinghuman Over a year ago

@G. Ann - SonarSource Team Where Can I find the logic of this rule common-java:DuplicatedBlocks ?

G. Ann - SonarSource Team Over a year ago

It's in SonarQube itself

beinghuman Over a year ago

@G. Ann - SonarSource Team .Would be quite interesting to know how this works.This rule is in sonarqube and rest of the rules starting with squid-xxxx are in sonar-java.Is Sonar using some external library to check code duplication?

beinghuman Over a year ago

@G. Ann - SonarSource Team Thank you for the hint ,I have figured out how copy code is working.

|

Carlos Cruz · Accepted Answer · 2020-03-17 16:35:13Z

26

You have to look (scroll down) your code. There will be a duplication marker in brown/gray like this:

answered Mar 17, 2020 at 16:35

Carlos Cruz

5155 silver badges6 bronze badges

5 Comments

akashdeep-mishra Over a year ago

Thanks, We could locate the duplicate block of code and the lines as mentioned clearly by you in the screenshot.

Glorin Over a year ago

Thanks you saved my day. The yellow background on code lines is really misleading.

Karan Sharma Over a year ago

Woah ! thanks man Sonarqube needs to do better at documentation. You saved the day !

Rajeev Pande Over a year ago

Thanks Carlos, your screenshot is a savior. I was scrolling mindlessly, and this gray marker wasn't catching my attention.

divine Over a year ago

@Carlos saved the day. thank you

Collectives™ on Stack Overflow

Duplicated block of Code in Sonar for import statements in Java

2 Answers 2

6 Comments

5 Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

5 Comments

Related