Changing file name with its directory name in a batch file

Question

I am trying to recursively change some file names according to their directory name but I am failed. Here is what I have done so far:

for /r %1 %%Z in (*.c) do ( echo ==== rem Change to the directory of .c file echo cd /d "%%~dpZ" cd /d "%%~dpZ" rem Change the file's name with its directory name with .c extension ren %%~nxZ %cd%.c )

And here is the directory structure:

SubDir renamer.bat sub1 file1.c sub2 file2.c so on so forth

All the other posts say that using %cd% returns the current directory's name, however it returns something like that: c:\users\myusername\desktop\SubDir,means it returns the batch file's directory name. However, as you can see, I use cd command in the batch file, so I want it to returns only sub1, sub2, etc... Thus, I can able to change the file names into their directory's name:

ren file1.c sub1.c

Thanks in advance.

EDIT: Answer

setlocal EnableDelayedExpansion for /r %1 %%Z in (*.c) do ( echo ==== rem Change to the directory of .c file echo cd /d "%%~dpZ" cd /d "%%~dpZ" rem Change the file's name with its directory name with .c extension FOR /f "delims=" %%a IN ("%%~dpZ\.") DO (ren %%~nxZ %%~nxa.c) )

Please do not provide a solution by editing the question, post it as an answer because that is what it is... — aschipfl
– aschipfl, Commented Mar 22, 2016 at 9:46

Magoo · Accepted Answer · 2016-03-21 21:17:21Z

2

 FOR /f "delims=" %%a IN ("%%~dpZ\.") DO ECHO(ren %%~nxZ %%~nxa-%%~nxZ

to echo the new name....

answered Mar 21, 2016 at 21:17

Magoo

80.8k8 gold badges68 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dennis van Gils · Accepted Answer · 2016-03-21 21:08:41Z

0

You should use delayed expansion in this case. You should use this:

setlocal EnableDelayedExpansion for /r %1 %%Z in (*.c) do ( echo ==== rem Change to the directory of .c file echo cd /d "%%~dpZ" cd /d "%%~dpZ" rem Change the file's name with its directory name with .c extension for /f "delims=" %%A in ("!CD!") do ren "%%~nxZ" "%%~nxA.c" )

For more information about delayed expansion, see this