Use #selector instead of explicitly constructing a Selector [duplicate]

Question

In the following snippet, what is the reason why Xcode recommend "Use #selector instead of explicitly constructing a Selector"?

// addButton = UIBarButtonItem.init(barButtonSystemItem: UIBarButtonSystemItem.Add, // target: self, action: #selector(FoldersMaintenanceVC.addButtonPressed)) addButton = UIBarButtonItem.init(barButtonSystemItem: UIBarButtonSystemItem.Add, target: self, action: Selector("addButtonPressed")) self.navigationItem.leftBarButtonItem = addButton func addButtonPressed() { myNslogSys2(self, funcName:#function) }

Valentin · Accepted Answer · 2016-03-24 15:53:07Z

9

It recommends that you use the Swift 2.2 new #selector because it is more type-safe since you cannot make a selector reference to a non-existing method whereas with Selector(String), you could reference a non-existing one.

edited Mar 24, 2016 at 15:53

answered Mar 24, 2016 at 15:46

Valentin

11.9k2 gold badges23 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user523234 Over a year ago

There is a flaw in this though. If I supply a wrong class that has an existing method but my intended target class - self, etc. does not have this existing method, it will crash at run time.

Kyle KIM Over a year ago

What can I do if i want to do something like this: if responder!.respondsToSelector(Selector("aMethod:")) == true{ ...}

Valentin Over a year ago

@KyleKIM If aMethod comes from a class or a protocol and is not optional, probably something like if let responder = responder as? Protocol { responder.aMethod(value) } Or otherwise if responder!.respondToSelector(#selector(Protocol.aMethod(_:)) { ... }

Chris · Accepted Answer · 2016-03-24 15:47:27Z

Using #selector is now the correct way in Swift to reference a selector. Use of the struct Selector and string literals for selectors, such as "mySel:" have been deprecated.

The new #selector is now type safe and allows for compiler checking and autocompletion of the selector that you're passing in. This fixes the very common mistake of a spelling mistake in your selector (in the case of string literals)

Peter K · Accepted Answer · 2016-03-24 15:48:30Z

It happens cause now construction of Selector from string literals deprecated and will be removed in Swift 3.0

With the introduction of the #selector syntax, we should deprecate the use of string literals to form selectors. Ideally, we could perform the deprecation in Swift 2.2 and remove the syntax entirely from Swift 3.

You can read more details about this change here https://github.com/apple/swift-evolution/blob/master/proposals/0022-objc-selectors.md

Collectives™ on Stack Overflow

Use #selector instead of explicitly constructing a Selector [duplicate]

3 Answers 3

3 Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Linked

Related