ExecutorService doesn't shut down from contextDestroyed() when stopping Tomcat

Question

I have a ExecutorService executor = Executors.newSingleThreadExecutor(); that i want to stop when the server is shutting down.

I have a class that implements ServletContextListener and it's annotated with @WebListener.

I have the two methods in that class:

@Override public void contextInitialized(ServletContextEvent servletContextEvent) { System.out.println("ServletContextListener started"); } @Override public void contextDestroyed(ServletContextEvent servletContextEvent) { executor.shutdown(); executor.shutdownNow(); System.out.println("ServletContextListener destroyed"); }

And I see that it prints what's in both of them when it's supposed to, but when I press the stop button once in intelij, I get:

SEVERE: The web application [] appears to have started a thread named [pool-2-thread-1] but has failed to stop it. This is very likely to create a memory leak.

Right after it printed ServletContextListener destroyed.

I need to press the stop button again to fully stop it.

Why it doesn't shutdown the ExecutorService even though it reached the executor.shutdown();? What am I doing wrong?

PS: this is the only ExecutorService I have and no other threads are made by me.

EDIT2:

The executor service is a field in a singleton class, it's initialized with the class:

private ExecutorService executor = Executors.newSingleThreadExecutor();

This is how the class is initialized (lazy initialization):

public static RoomsManager getRoomsManager(ServletContext servletContext) { if (servletContext.getAttribute(MANAGER_GAMES_ATTRIBUTE_NAME) == null) { servletContext.setAttribute(MANAGER_GAMES_ATTRIBUTE_NAME, new RoomsManager()); } return (RoomsManager)servletContext.getAttribute(MANAGER_GAMES_ATTRIBUTE_NAME); }

And is annotated like this:

@WebListener public class RoomsManager implements ServletContextListener {

The stop button is the red square near the play and debug buttons in intelij IDEA.

Can you implement shutdown on these lines? stackoverflow.com/questions/36644043/… — Ravindra babu
– Ravindra babu, Commented Oct 25, 2016 at 10:25
@Ravindrababu I copied it into contextDestroyed(), it didn't change anything. It doesn't print the ("Pool did not terminate"); though. I Also tried 1 sec instead of 60. — shinzou
– shinzou, Commented Oct 25, 2016 at 10:31
change if (!pool.awaitTermination(60, TimeUnit.SECONDS)) condition to while condition and sleep for 60 seconds. while i(!pool.awaitTermination(60, TimeUnit.SECONDS)){ Thread.sleep(1000);} — Ravindra babu
– Ravindra babu, Commented Oct 25, 2016 at 10:33
@Ravindrababu still the same, I even waited more than a minute. BTW, the executor already finished the tasks it was given and doesn't receive any more by the time I check. — shinzou
– shinzou, Commented Oct 25, 2016 at 10:41
Create a ThreadFactroy, to name the threads within your pool. That way you can see if the remaining pool is yours, or if there are more. — Stefan
– Stefan, Commented Oct 25, 2016 at 10:58

Roman · Accepted Answer · 2016-10-28 19:46:54Z

The problem is that you have two different RoomsManager instances (and hence, two different executors): first is created by Tomcat, and second is created by you.

When you annotate RoomsManager with @WebListener, Tomcat automatically creates an instance of that class and subscribes it to receive servlet context create/destroy events. That instance is the one that actually stops its executor and prints ServletContextListener destroyed.

The second instance is created by you in the getRoomsManager method (by the way, that method doesn't look thread-safe). That instance is not registered with Tomcat and doesn't receive servlet context "destroy" event, so it doesn't even try to shutdown its executor.

How can I get the instance that tomcat creates? And you're right it isn't thread safe now that I look at it.
@kuhaku For example, RoomsManager can do servletContextEvent.getServletContext().setAttribute(..., this) inside its contextInitialized() method, so you'll be able to call getAttribute(...) to get it.
Thanks that did it. They really should improve their documentation, I didn't see anywhere it mentioned that tomcat creates an instance on its own. tomcat.apache.org/tomcat-7.0-doc/servletapi/javax/servlet/…
@kuhaku It's kinda implied, since that was the way it worked with web.xml. And web annotations are really an extension of web.xml.

shinzou · Accepted Answer · 2016-10-28 15:39:06Z

Doing this worked:

class YourThreadFactory implements ThreadFactory { public Thread newThread(Runnable r) { return new Thread(r, "Your name"); } } private ExecutorService executor = Executors.newSingleThreadExecutor(new YourThreadFactory());

Because apparently, the threads of tomcat are daemons, and therefore, when they create a new thread with return new Thread(r, "Your name"); it also becomes a daemon.

But in the DefaultThreadFactory that an executor service use, I saw that it makes sure daemonity of new threads is off.

That doesn't explain why executor.shutdown(); didn't work though, but now at least it properly shuts down.

Collectives™ on Stack Overflow

ExecutorService doesn't shut down from contextDestroyed() when stopping Tomcat

2 Answers 2

4 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Linked

Related