How to determine whether number has digits in ascending order from right to left

Question

I need to determine whether an entered number has digits in ascending order from right to left.

My code seems not working correctly

Here is my code:

int n, temp; cout << "Please enter number: "; cin >> n; bool ascending = true; temp = n%10; while (n>0) { n /= 10; if (temp < n % 10) { ascending = false; } } if (ascending) { cout << "Number is ascending"; } else { cout << "Number is not ascending"; }

In situations like this, it is best to use a debugger. Debuggers can be intimidating for beginners, so the quick alternative is to stick in a few couts to keep updated on the values of variables and where the control flow is going. — Paul Rooney
– Paul Rooney, Commented Jan 14, 2017 at 12:03

Thirupathi Thangavel · Accepted Answer · 2017-01-14 12:32:35Z

1

You're not updating the value of temp after every iteration

int n, temp; cout << "Please enter number: "; cin >> n; bool ascending = true; temp = n%10; while (n / 10 > 0) { n /= 10; if (temp > n % 10) { ascending = false; break; } temp = n % 10; } if (ascending) { cout << "Number is ascending"; } else { cout << "Number is not ascending"; }

edited Jan 14, 2017 at 12:32

answered Jan 14, 2017 at 11:59

Thirupathi Thangavel

2,5154 gold badges32 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

barak manos Over a year ago

You can also break after setting ascending = false.

Andrew Over a year ago

@Thirupathi Thangavel oh ye right, thank you, but it still not output correct answer, for example for number "5321" - output is not ascending

Thirupathi Thangavel Over a year ago

@Andrew Check now

Andrew Over a year ago

@Thirupathi Thangavel still the output is not correct

doug Over a year ago

"ascending" or "ascending consecutively? the answer is correct for the former but not for the latter.

|

ChuckB · Accepted Answer · 2017-01-14 13:16:06Z

When I run the latest from Thirupathi, it does work. Note OP said ascending order RIGHT to LEFT.

Ex output runs:

./order Please enter number: 5321 Number is ascending ./order Please enter number: 2356 Number is not ascending

Collectives™ on Stack Overflow

How to determine whether number has digits in ascending order from right to left

2 Answers 2

6 Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

1 Comment

Related