Count the consecutive 1-bit without overlapping

Question

Determine the number of 1-bit pairs without overlap with other pairs in C. But My code does not include the first number. Like 11011 has 2 pairs of 1-bit but my output gives me 1 pair because it did not include the first number.

int numPairs(int n){ int count=0; bool prevOne=0; while(n!=0){ bool currOne=(n&1)==1; if(currOne && !prevOne) count++; n=n>>1; prevOne=!currOne; } return count/2; }

Why not mask with 11 and skip 2 bits if found (one if not)? — Eugene Sh.
– Eugene Sh., Commented Mar 5, 2019 at 19:25
Did you mean to say prevOne=currOne? Why are you dividing by 2? — Neil
– Neil, Commented Mar 5, 2019 at 19:51
Could you edit your title or your text, as one talks about counting pairs, and one about counting the number of consecutive '1' which I would say is 4 for 1111, but it's only 2 pairs of '1'. And/or add another example of results expected for 11110111 — B. Go
– B. Go, Commented Mar 5, 2019 at 22:48

user3629249 · Accepted Answer · 2019-03-07 00:37:30Z

2

int numPairs(int n) { int count=0; bool prevOne=0; // 1 if previous bit was 1. while(n!=0) { bool currOne=(n&1)==1; if(currOne && prevOne) count++; n=n>>1; prevOne=currOne; } return count; // no need divide count by 2 as count exactly specifies number of 1bit pairs. }

edited Mar 7, 2019 at 0:37

user3629249

16.6k1 gold badge18 silver badges17 bronze badges

answered Mar 5, 2019 at 19:38

priojeet priyom

9089 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user3629249 Over a year ago

nice answer, However, we would like to be able to easily read/understand it. A major step in the understanding is if it were properly indented. Suggest 1) always include the optional braces '{}" 2) indent after every opening brace '{'. 3) unindent before every closing brace '}'. Suggest each indent level be 4 spaces

priojeet priyom Over a year ago

I usually indent my code. But could not find any efficient way of doing it when writing answer from android.

user3629249 Over a year ago

I modified your answer by inserting the appropriate indentation

Collectives™ on Stack Overflow

Count the consecutive 1-bit without overlapping

1 Answer 1

3 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Related