Better way of rewriting below method [duplicate]

Question

I have below method that does work Okay but I believe we can make it better by some how getting rid of these if conditions, but not sure how?

 protected void SaveSession<T>(T sessionProperty, Management management) where T : class { string propertyType = typeof(T).Name; if (propertyType.Equals(typeof(A).Name)) { management.A = sessionProperty as A; } else if (propertyType.Equals(typeof(B).Name)) { management.B = sessionProperty as B; } else if (propertyType.Equals(typeof(C).Name)) { management.C = sessionProperty as C; } Session["mysession"] = management; }

I am using latest C# version 7.0

Which C# version are you using? In C# 7 and later you can use a pattern matching switch statement — Panagiotis Kanavos
– Panagiotis Kanavos, Commented Jun 13, 2019 at 15:29
Get an ArrayList property in Management. Filter with Enumerable.OfType() and add/set the sessionProperty variable. — Cleptus
– Cleptus, Commented Jun 13, 2019 at 15:30
Sounds like a good place for the strategy pattern. Other than that, don't compare type names, just compare the types directly. — Alejandro
– Alejandro, Commented Jun 13, 2019 at 15:34
@User the latest released version is 7.3. The latest preview version is 8.0. I assume you use C# 7.3, or at least C# 7? — Panagiotis Kanavos
– Panagiotis Kanavos, Commented Jun 13, 2019 at 15:35

Panagiotis Kanavos · Accepted Answer · 2019-06-13 15:32:22Z

3

In C# 7 and later you can use a pattern matching switch statement, eg :

switch(sessionProperty) { case A a: management.A=a; break; case B b: management.B=b; break; case C c: management.C=c; break; }

In earlier versions you can use the is operator to check the type, eg :

if (sessionProperty is A) { management.A=(A)sessionProperty; } else if (sessionProperty is B) { management.B=(B)sessionProperty; }

answered Jun 13, 2019 at 15:32

Panagiotis Kanavos

134k16 gold badges211 silver badges270 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

User Over a year ago

sorry I am using I am using latest C# version 7.0

Cleptus Over a year ago

If Management could be changed, I would suggest an ArrayList property in it + .OfType<T>()

Panagiotis Kanavos Over a year ago

@User pattern matching works in C# 7

Panagiotis Kanavos Over a year ago

@bradbury9 why do that?

Cleptus Over a year ago

To reduce the amount of properties in Management. Seems like a poor design

|

Collectives™ on Stack Overflow

Better way of rewriting below method [duplicate]

1 Answer 1

9 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Linked

Related