Easier way to verify input is >0 in Python?

Question

I've written function enterReadings for the user to enter a number and I've got the following verification to ensure it's a positive integer. I'm thinking that there's a simpler way to write this but don't know where to start, any help is massively appreciated!

def enterReadings(message): while True: try: readingsCount = int(input(message)) if readingsCount <= 0: print("Please enter a positive integer") continue break except ValueError: print("Please enter a positive integer") readingsCount = 0 if readingsCount > 0: readingsCount += readingsCount return readingsCount

if readingsCount > 0 to check for a +ve number should be good enough. — Mayank Porwal
– Mayank Porwal, Commented Apr 9, 2020 at 10:20
Your last if can be removed and the lines under it should replace the break. I don't think that break does what you mean anyway. — Jongware
– Jongware, Commented Apr 9, 2020 at 10:20
Do you really want to break from the loop and return (implicit) None if a positive integer was entered? — Matthias
– Matthias, Commented Apr 9, 2020 at 10:24

Błotosmętek · Accepted Answer · 2020-04-09 10:47:43Z

3

A bit shorter:

def enterReadings(message): while True: try: readingsCount = int(input(message)) assert readingsCount > 0 return readingsCount except: print("Please enter a positive integer")

BTW why do you double your readingsCount? Is that what you intended?

edited Apr 9, 2020 at 10:47

answered Apr 9, 2020 at 10:27

Błotosmętek

13k23 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

r0llie Over a year ago

Ah amazing thank you. No the doubling of readingsCount is an error on my part!

Jongware Over a year ago

Suggestion for the first line: def enterReadings(message:str="Enter a positive number: ") -> int:

Matthias Over a year ago

In the original code readingsCount isn't doubled. The program never reaches that part of the code.

Błotosmętek Over a year ago

Sure, change int to float.

Michael · Accepted Answer · 2020-04-09 10:29:33Z

In python, int can also be negative, so you have to check it.

Python 3.8+:

def enterReadings(message): while True: try: if (n := int(input(message))) > 0: return 2*n except ValueError: pass print("Please enter a positive integer")

Aliaksei Piatrouski · Accepted Answer · 2020-04-09 10:26:12Z

-1

I think it is absolutely OK, you check if an input is a number (int) and is positive.

Clear is better than clever.

answered Apr 9, 2020 at 10:26

Aliaksei Piatrouski

771 silver badge3 bronze badges

1 Comment

Jongware Over a year ago

It is not okay. Try to print out the returned result for a correct entry.

Collectives™ on Stack Overflow

Easier way to verify input is >0 in Python?

3 Answers 3

4 Comments

Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

1 Comment

Related