javascript date returns undefined

Question

im making it display the time in javascript but when it returns the time it is always undefined. below is the code

im not really sure why it always returns undefined though.

$('#bar #time').html(hours + ":" + minutes + " " + suffix); var currentTime = new Date() var hours = currentTime.getHours() var minutes = currentTime.getMinutes() //decides if am or pm var suffix = "AM"; if (hours >= 12) { suffix = "PM"; hours = hours - 12; } if (hours == 0) { hours = 12; } // shows 0 before the minutes if under 10 if (minutes < 10) minutes = "0" + minutes

the time was returning undefined but i fixed it by moving the jquery call down to the bottom — user645607
– user645607, Commented Jun 19, 2011 at 6:46

user578895 · Accepted Answer · 2011-06-19 06:43:06Z

um, if the code is in that order, you just need to put your first line at the end, as hours, minutes and suffix are all undefined at that point. Other than that it should work fine (and does, per chrome console).

Scott · Accepted Answer · 2011-06-19 07:38:31Z

Not entirely related to your actual question, but $('#bar #time') is going to be a fairly inefficient jQuery selector. Since IDs are only used once in your document, searching simply for $('#time') will give you the same result and only require the JavaScript engine to to fire document.getElementById once rather than twice.

Minor point, but worth mentioning.

Adithya Surampudi · Accepted Answer · 2011-06-19 06:45:23Z

0

No semicolons here

var currentTime = new Date() var hours = currentTime.getHours() var minutes = currentTime.getMinutes()

answered Jun 19, 2011 at 6:45

Adithya Surampudi

4,4441 gold badge20 silver badges17 bronze badges

3 Comments

alex Over a year ago

Whilst bad practice, not the problem.

Bodman Over a year ago

javascriot auto injects semicolons.

user645607 Over a year ago

yeah i forgot those, oops. i fixed it though.

Bodman · Accepted Answer · 2011-06-19 06:48:16Z

$(document).ready(function(){ var currentTime = new Date() var hours = currentTime.getHours() var minutes = currentTime.getMinutes() //decides if am or pm var suffix = "AM"; if (hours >= 12) { suffix = "PM"; hours = hours - 12; } if (hours == 0) { hours = 12; } // shows 0 before the minutes if under 10 if (minutes < 10) minutes = "0" + minutes $('#bar').html(hours + ":" + minutes + " " + suffix); });

The order in which you print your variables matters,

they were not defined upon printing.

Collectives™ on Stack Overflow

javascript date returns undefined

4 Answers 4

Comments

Comments

3 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

3 Comments

Comments

Related