Swapping elements in array doesn't work when using function pointer

Question

So i want to use AscendingSort() and DecendingSort() as an argument but it seems like after return the value the swap part just get skipped, hope someone explain to me, thanks!.

 bool AscendingSort(int a, int b) { return a > b; } bool DecendingSort(int a, int b) { return a < b; } void SortArray(int* a, int size, bool(*func)(int, int)) { int saveElement; for (int x = 0; x < size; x++) { for (int y = x + 1; y < size; y++) { if (func(a[x], a[y])) { saveElement = a[x]; a[x] == a[y]; //Those 2 lines getting skipped. a[y] == saveElement; } } } } void main() { int a[1000]; int arrSize; SortArray(a, arrSize, AscendingSort); };

Is this really the code you are running? Because you neither initialized a nor arrSize, causing the function call to be full of undefined behavior — UnholySheep
– UnholySheep, Commented Aug 3, 2022 at 9:52
whats wrong with the code? What do you mean with "//Those 2 lines getting skipped." ? How did you arrive at that conclusion? — 463035818_is_not_an_ai
– 463035818_is_not_an_ai, Commented Aug 3, 2022 at 9:53
Instead of hand coding swap use std::swap en.cppreference.com/w/cpp/algorithm/swap available in the standard library. — DailyLearner
– DailyLearner, Commented Aug 3, 2022 at 9:57

Pajunen · Accepted Answer · 2022-08-03 09:54:05Z

5

You probably meant to use = operator instead of ==.

answered Aug 3, 2022 at 9:54

Pajunen

1161 silver badge2 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Trong Thang Over a year ago

Lol, sorry, that was a dumbest mistake

Collectives™ on Stack Overflow

Swapping elements in array doesn't work when using function pointer

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related