document.getElementById doesnt seem to work

Question

I am trying to execute this but cant see any result:

<script> function init() { document.getElementById('welcome').innerHTML = "<font color=white>Logged As:"+ param + "</font>"; } window.onload = init; </script> <body> ........... <div class="span-24 bottom_header" id="welcome"></div> ........... </body>

what is wrong here..........

What browser? is window.onload being called? Try putting an alert('hi') in your init() ? — Chad Grant
– Chad Grant, Commented May 2, 2009 at 11:36
The only reason this doesn't work is because param is undefined. (Like Perspx suggested). No idea why you've accepted the answer you have below - doesn't solve your problem... — James
– James, Commented May 2, 2009 at 12:56

Darin Dimitrov · Accepted Answer · 2009-05-02 11:39:23Z

8

Maybe because your background is white and you are setting white color to your font: <font color=white>. Try with black :-)

answered May 2, 2009 at 11:39

Darin Dimitrov

1.0m276 gold badges3.3k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

RichieHindle · Accepted Answer · 2009-05-02 11:42:02Z

This self-contained example works perfectly for me in Firefox and IE7:

<html><head><script> function init() { document.getElementById('welcome').innerHTML = "<font color=white>Logged As: TEST</font>"; } window.onload = init; </script></head> <body> <div class="span-24 bottom_header" id="welcome"></div> </body></html>

You are adding white-on-white text, remember...

In your code you removed param therefore it worked. As JimmyP said the problem is because param is undefined.

Nathan Ridley · Accepted Answer · 2009-05-02 11:46:32Z

Two things:

1) Make sure you don't have more than one element on the page with the ID "welcome"

2) Off topic, but revise your need to use the "font" tag. It's heinously deprecated at this point in time. You should be using <span style="color:white;">Logged as: TEST</span>

Andreas Grech · Accepted Answer · 2009-05-02 14:41:42Z

Perspx and JimmyP already mentioned this in the Question's comments:

Are you sure you the param variable exists somewhere before executing your function?

Andreas Grech · Accepted Answer · 2009-05-03 11:25:27Z

3

Have you considered using a framework such as jquery? The above code would then become...

$('#welcome').html("<font color='white'>Logged As: TEST</font>");

edited May 3, 2009 at 11:25

Andreas Grech

108k102 gold badges303 silver badges362 bronze badges

answered May 2, 2009 at 11:38

Ian Roke

1,7841 gold badge19 silver badges28 bronze badges

13 Comments

Chad Grant Over a year ago

Pretty harsh downvote, the example code is almost always a snippet.

Ian Roke Over a year ago

You marked me down for such a suggestion? I'm assuming that isn't the only thing he will be wanting to do with JS so I was simply making a suggestion he uses a framework to simplify things.

Andreas Grech Over a year ago

All I'm saying is using jQuery won't solve his problem...and will most probably even create more problems for him

Ian Roke Over a year ago

OK fair enough. I am of the opinion that a framework is designed to make things easier not the other way round. I'm beginning to realise that offering alternative suggestions is something that is frowned upon on here.

James Over a year ago

Not only is jQuery not required for this simple task but the code posted won't work. I think you meant $('.welcome').text('...');

|

ken · Accepted Answer · 2009-05-03 11:30:40Z

Actually, the correct jQuery translation would be:

$('#welcome').html("<font color='white'>Logged As: TEST</font>");

Three cheers for my lack of "reputation"!

Collectives™ on Stack Overflow

document.getElementById doesnt seem to work

6 Answers 6

Comments

1 Comment

Comments

Comments

13 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

1 Comment

Comments

Comments

13 Comments

Comments

Related