Skip to content

Conversation

@nyanhp
Copy link
Member

@nyanhp nyanhp commented Nov 13, 2025

Description

Lots of changes, and surely I missed one or two temporary files that we don't remove, but this PR
should fix #1610 by making our deployment directory configurable by setting VMDeploymentFilesFolder.
The default has been updated
to $([Environment]::GetFolderPath(''ApplicationData''))/DeployDebug. It might seem overly complicated,
but this way we guarantee a working folder on Linux and Windows guests. The expression is evaluated in our
invokes.

This however means that future roles should take into consideration that temp files are removed, and
static content is placed within the new directory.

  • - I have tested my changes.
  • - I have updated CHANGELOG.md and added my change to the Unreleased section
  • - The PR has a meaningful title.
  • - I updated my fork/branch and have integrated all changes from AutomatedLab/develop before creating the PR.

Type of change

  • Bug fix
  • New functionality
  • Breaking change
  • Documentation

How was the change tested?

Tested roles will be checked when I tested them:

  • ADDS
  • ADCS
  • ConfigMgr
  • Applying DSC Configs
  • Dynamics
  • SCOM
  • SCVMM
  • SQL
  • Tfs/Build Agents
  • WAC
  • SharePoint
# The DSC Lab including these four lines instead of the Host and the three web and file servers Add-LabIsoImageDefinition -Name Scvmm2022 -Path $labSources\ISOs\mul_system_center_virtual_machine_manager_2022_x64_dvd_fed2ae0f.iso Add-LabIsoImageDefinition -Name ScomManagement -Path $labsources\ISOs\mu_system_center_operations_manager_2019_x64_dvd_b3488f5c.iso Add-LabMachineDefinition -Name DSCVM01 -Memory 4GB -Roles Scvmm2022 -IpAddress 192.168.111.71 -operatingsystem 'Windows Server 2019 Datacenter Evaluation (Desktop Experience)' Add-LabMachineDefinition -Name DSCOM01 -Memory 4GB -Roles ScomManagement -IpAddress 192.168.111.72 -operatingsystem 'Windows Server 2019 Datacenter Evaluation (Desktop Experience)' # Afterwards "configuration foo {node 'DSCCASQL01' {File foo {DestinationPath = 'C:\tst'; Type = 'File'}}}" | set-content bla.ps1 . .\bla.ps1 Invoke-LabDscConfiguration -Verbose -Configuration (Get-Command foo -CommandType Configuration) -ComputerName DSCCASQL01 -Wait Set-LabDscLocalConfigurationManagerConfiguration -ComputerName DSCCASQL01 -ActionAfterReboot ContinueConfiguration
@nyanhp nyanhp marked this pull request as ready for review November 18, 2025 14:14
@nyanhp
Copy link
Member Author

nyanhp commented Nov 18, 2025

Regarding SCVMM: The setup works, in general (as in: All new paths work), but there appear to be some issues that I am tracking separately. SCVMM has issues with the ADK which now contains a different set of subfolders than it used to, so we need to download different version for the different VMM versions.

@nyanhp nyanhp requested a review from raandree November 18, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant