This repository was archived by the owner on Mar 4, 2024. It is now read-only.
Macro parser improvements #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is a rewrite of the attribute parser in gtk3-macros. It will now print clear error messages that are annotated at the correct span.
| @@ -0,0 +1,180 @@ | |||
| use proc_macro2::Span; | |||
Member Author
There was a problem hiding this comment.
That's how it apparently always was. So we need to fix that after this PR, and also in gtk4 (CC @bilelmoussaoui )
Member
There was a problem hiding this comment.
Ok, I'll let you open the issue then. ;)
Member Author
There was a problem hiding this comment.
Ah you said I should, ok!
Member
| Thanks! |
Member Author
| @GuillaumeGomez You create an issue? |
This was referenced Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backport of gtk-rs/gtk4-rs#103