Restore prometheus metric name mapper tests, fix regressions #6138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jack-berg commented Jan 10, 2024
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java Show resolved Hide resolved
jack-berg commented Jan 10, 2024
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java Show resolved Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #6138 +/- ## ============================================ + Coverage 91.01% 91.07% +0.06% - Complexity 5702 5706 +4 ============================================ Files 630 630 Lines 16710 16711 +1 Branches 1656 1657 +1 ============================================ + Hits 15208 15219 +11 + Misses 1047 1039 -8 + Partials 455 453 -2 ☔ View full report in Codecov by Sentry. |
jack-berg commented Jan 10, 2024
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java Outdated Show resolved Hide resolved
jack-berg commented Jan 10, 2024
.../prometheus/src/test/java/io/opentelemetry/exporter/prometheus/PrometheusHttpServerTest.java Show resolved Hide resolved
Member Author
psx95 reviewed Jan 11, 2024
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java Outdated Show resolved Hide resolved
psx95 reviewed Jan 11, 2024
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java Outdated Show resolved Hide resolved
psx95 reviewed Jan 11, 2024
Contributor
psx95 left a comment
psx95 left a comment There was a problem hiding this comment.
Thanks for addressing the post-merge comments, @jack-berg !
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java Outdated Show resolved Hide resolved
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java Outdated Show resolved Hide resolved
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java Show resolved Hide resolved
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java Show resolved Hide resolved
fstab reviewed Jan 11, 2024
...ers/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusUnitsHelper.java Show resolved Hide resolved
psx95 reviewed Jan 11, 2024
...metheus/src/test/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverterTest.java Outdated Show resolved Hide resolved
trask reviewed Jan 11, 2024
.../prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Otel2PrometheusConverter.java Show resolved Hide resolved
jack-berg changed the title trask approved these changes Jan 11, 2024
Member Author
psx95 approved these changes Jan 11, 2024
Contributor
psx95 left a comment
psx95 left a comment There was a problem hiding this comment.
Looks good now! Thank you for addressing the concerns! 👍🏻
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Addressing post-merge comments on #6015.
Fixing a few things that might qualify as regressions:
1toratioin the simple case. I.e. we convert1{foo}toratio, but1result innull. Not sure why but I think that's wrong.