Fix numba cache bugs and suppress noisy warnings #1731
Merged
+228 −107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (96.87%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
@@ Coverage Diff @@ ## main #1731 +/- ## ======================================= Coverage 81.71% 81.71% ======================================= Files 251 251 Lines 54112 54112 Branches 9470 9471 +1 ======================================= Hits 44215 44215 Misses 7409 7409 Partials 2488 2488
🚀 New features to boost your workflow:
|
ricardoV94 force-pushed the fix_numba_fgraph_key branch from f8bd89f to e45f80d Compare 
ricardoV94 force-pushed the fix_numba_fgraph_key branch 2 times, most recently from 6653e3e to a693592 Compare ricardoV94 changed the title ricardoV94 changed the title 
ricardoV94 commented Nov 19, 2025
| if config.numba__cache and py_func in CACHED_SRC_FUNCTIONS: | ||
| return cls(py_func, Path(py_file).parent, CACHED_SRC_FUNCTIONS[py_func]) | ||
| if py_func in CACHED_SRC_FUNCTIONS and config.numba__cache: | ||
| return cls(py_func, py_file, CACHED_SRC_FUNCTIONS[py_func]) |
Member Author
There was a problem hiding this comment.
Numba wants a string for py_file (to emit warnings)
ricardoV94 force-pushed the fix_numba_fgraph_key branch 2 times, most recently from 7410ed7 to 90c8027 Compare ricardoV94 force-pushed the fix_numba_fgraph_key branch 2 times, most recently from c23a3b7 to 53680c5 Compare 
jessegrabowski approved these changes Nov 25, 2025
It's necessary to encode the edge information, not only the nodes and their ordering
Implementation was specializing on node repeated inputs an `unique_names` would return the same name for repeated inputs. The cache key didn't account for this. We also don't want to compile different functions for different patterns of repeated inputs as it doesn't translate to an obvious handle for the compiler to specialize upon. We we wanted to inline constants that may make more sense.
It's more readable and avoids potential bugs when force_unique is not set to True
ricardoV94 force-pushed the fix_numba_fgraph_key branch from be4eb61 to 608b699 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.