This repository was archived by the owner on Oct 14, 2023. It is now read-only.
fix: increase batch translate timeout to 300 #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
lesv approved these changes Aug 26, 2020
Codecov Report
@@ Coverage Diff @@ ## master #274 +/- ## ========================================= Coverage 69.90% 69.90% Complexity 220 220 ========================================= Files 23 23 Lines 1668 1668 Branches 46 46 ========================================= Hits 1166 1166 Misses 457 457 Partials 45 45 Continue to review full report at Codecov.
|
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 30, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.95.3](https://www.github.com/googleapis/java-translate/compare/v1.95.2...v1.95.3) (2020-10-30) ### Bug Fixes * increase batch translate timeout to 300 ([#274](https://www.github.com/googleapis/java-translate/issues/274)) ([75736fe](https://www.github.com/googleapis/java-translate/commit/75736fe03ee1298ee153ce9baeb8c81ec82df8a0)) * use setModel as rest api already support it ([#330](https://www.github.com/googleapis/java-translate/issues/330)) ([de5b5a8](https://www.github.com/googleapis/java-translate/commit/de5b5a80fb9e42cf698fd101cffd34474eda0ce9)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.13.0 ([#318](https://www.github.com/googleapis/java-translate/issues/318)) ([41293ce](https://www.github.com/googleapis/java-translate/commit/41293ce8a0e6cb410ba0f4a80a8027bc5ee49b3d)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.0 ([#281](https://www.github.com/googleapis/java-translate/issues/281)) ([e028946](https://www.github.com/googleapis/java-translate/commit/e02894607fea4edaa04486709a0e438a5f5beb20)) * update dependency com.google.cloud:google-cloud-storage to v1.113.2 ([#277](https://www.github.com/googleapis/java-translate/issues/277)) ([ed76cd5](https://www.github.com/googleapis/java-translate/commit/ed76cd53a5a2db0214b1c0986009c7cee7428384)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #267 ☕️
average time batch translate LRO to complete is between 1-3min but sometimes it takes 4-5 min to complete.