feat(default_retention_period): Changes to copy backup path to support null expire time #963
+269 −10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…rt null expire time With the default retention period feature, null value for expiration time is a valid value. If the expiration time is not specified (null) at the time of create backup then the backup will be retained for the duration of maximum retention period. In this commit, the precondition check on expiration time in the create backup API path is removed. The condition remains intact for copy backup API and that would be addressed in a follow-up commit.
…t null expire time With the default retention period feature, null value for expiration time is a valid value. If the expiration time of the destination backup is not specified (null) at the time of copy backup then the destination backup will be created with the expiration time of the source backup. In this commit, the precondition check on expiration time in the copy backup path is removed.
product-auto-label bot added size: l Author
| @asthamohta Could you review this diff. Also, can you please add "do not merge" tag on this diff since the backend changes are not merged. |
asthamohta approved these changes Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With the default retention period feature, null value for expiration time
is a valid value. If the expiration time of the destination backup is not
specified (null) at the time of copy backup then the destination backup
will be created with the expiration time of the source backup.
In this commit, the precondition check on expiration time in the copy
backup path is removed.
Fixes # 288399059