Thread: Problem in AWT and IFrame implementaion

hi all and thanks for all the help previously and i was wondering if you could check it over and point out any errors i might of missed

my credit class

public class Credit {  	private float credit;  	public Credit(){	credit = 0;	}  	public float addCredit(){  	credit = + 10;  	return credit;  	} }

my dispenser class

import javax.swing.JOptionPane;     public class Dispencer {  	private String itemID;	private String itemName; private int itemPrice; private int itemQuantity; boolean items;   public Dispencer(String id, String in, int ip, int iq) {	itemID = id;	itemName = in; itemPrice = ip; itemQuantity = iq; }   public String getItemID() {	return(itemID); }   public String getItemName() {	return(itemName); }   public int getItemPrice() {	return(itemPrice); }   public int getItemQuantity() {	return(itemQuantity); }   public void replaceItemQuantity(int iq) { itemQuantity = iq;	}   public void replaceItemPrice(int ip) { itemPrice = ip; }   public String getItemValues() {	if (!itemID.equals(""))	return "Item ID: " + itemID + "Item Name: " + itemName + " Price: " + itemPrice + " Quantity:" + itemQuantity + "\n";	else	return(""); }   public boolean itemsLeft(){    	if ((itemQuantity <1))	items = false;	else	items = true;  	return (items);	}   public void dispenceItem() {	if (itemQuantity >0)	itemQuantity = itemQuantity - 1;	else	{	JOptionPane.showMessageDialog(null, "No items left");	}	} }

and my GUI

import java.awt.Color; import java.awt.Dimension; import java.awt.FlowLayout; import java.awt.event.ActionEvent; import java.awt.event.ActionListener; import javax.swing.*; import java.util.*;   public class DispencerMachineGUI extends JFrame implements ActionListener {  	private JPanel entryPanel;	private JTextArea displayArea;	private JLabel itemID, itemName, itemPrice, itemQuantity, credit;	private JTextField itemIDTextField, itemNameTextField, itemPriceTextField, itemQuantityTextField, creditTextField;	private JButton addItem, dispItem, addCredit, purchaseItem, changePrice, changeQuantity;	private int counter;	private Dispencer dp1;	private Credit c;	private ArrayList <Dispencer> item;  	public static void main(String[] args)  	{	new DispencerMachineGUI();	}  	public DispencerMachineGUI()	{  	setLayout(new FlowLayout());	entryPanel = new JPanel();	entryPanel.setPreferredSize(new Dimension(400, 120));	entryPanel.setBackground(Color.lightGray);  	itemID = new JLabel("Product ID (starting from 0): ");	itemName = new JLabel("Product Name: ");	itemPrice = new JLabel("Product Price (p): ");	itemQuantity = new JLabel("Product Quantity : ");	credit = new JLabel("Total Credit ");  	creditTextField = new JTextField(10);	itemIDTextField = new JTextField(20);	itemNameTextField = new JTextField(20);	itemPriceTextField = new JTextField(20);	itemQuantityTextField = new JTextField(20);  	entryPanel.add(itemID);	entryPanel.add(itemIDTextField);	entryPanel.add(itemName);	entryPanel.add(itemNameTextField);	entryPanel.add(itemPrice);	entryPanel.add(itemPriceTextField);	entryPanel.add(itemQuantity);	entryPanel.add(itemQuantityTextField);  	addItem = new JButton("Add Item(s)");	addItem.setForeground(Color.red);	dispItem = new JButton("Display All Items");	dispItem.setForeground(Color.blue);	addCredit = new JButton("Add Credit");	addCredit.setForeground(Color.blue);	purchaseItem = new JButton("Purchase Item");	purchaseItem.setForeground(Color.blue);	changePrice = new JButton("Change the price of an item");	changePrice.setForeground(Color.blue);	changeQuantity = new JButton("Change the quantity of an item");	changeQuantity.setForeground(Color.blue);  	displayArea = new JTextArea();	displayArea.setPreferredSize(new Dimension(400, 200));	displayArea.setBackground(Color.lightGray);  	add(entryPanel);	add(addItem);	add(dispItem);	add(addCredit);	add(credit);	add(creditTextField);	add(displayArea);	add(changePrice);	add(changeQuantity);	add(purchaseItem);	addItem.addActionListener(this);	dispItem.addActionListener(this);	addCredit.addActionListener(this);	purchaseItem.addActionListener(this);	changePrice.addActionListener(this);	changeQuantity.addActionListener(this);  	dispItem.setEnabled(false);	addCredit.setEnabled(false);	purchaseItem.setEnabled(false);	changePrice.setEnabled(false);	changeQuantity.setEnabled(false);  	setTitle("Vending Machine");	setSize(450, 500);	setVisible(true);  	item = new ArrayList <Dispencer>();	c = new Credit();	counter = 0;    	creditTextField.setText("0");  	}  	public void actionPerformed(ActionEvent e)	{  	//Adding to available Credit  	if (e.getSource() == addCredit)	{	float totalMoney = c.addCredit();	c.credit = c.credit - totalMoney;	creditTextField.setText(Float.toString(totalMoney));	}  	//Adding items to array  	if (e.getSource() == addItem)	{	String iid, itn;	int itp, itq;	if(counter <5)	{	iid = itemIDTextField.getText();	itn = itemNameTextField.getText();	itp = Integer.parseInt(itemPriceTextField.getText());	itq = Integer.parseInt (itemQuantityTextField.getText());  	dp1 = new Dispencer(iid, itn, itp, itq);	item.add(counter, (Dispencer) dp1);  	itemIDTextField.setText("");	itemNameTextField.setText("");	itemPriceTextField.setText("");	itemQuantityTextField.setText("");  	counter ++;  	if(counter > 4)	{	dispItem.setEnabled(true);	addCredit.setEnabled(true);	purchaseItem.setEnabled(true);	changePrice.setEnabled(true);	changeQuantity.setEnabled(true);	}	}	else	{	JOptionPane.showMessageDialog(null, "The maximum of 5 items have been entered");	}	}  	//Displaying all items in array  	if (e.getSource() == dispItem)	{	String allItems="";	for (int i=0; i<5; i++)	{	allItems = allItems + item.get(i).getItemValues() +"\n";	}	displayArea.setText(allItems);  	}  	//Changing the price of an item  	if (e.getSource() == changePrice)	{	int whichitem;	String allItems="";	whichitem = Integer.parseInt(JOptionPane.showInputDialog(null,"Enter the ID of the item to be modified"));	int newItemPrice = Integer.parseInt(JOptionPane.showInputDialog(null,"Enter the new price"));	item.get(whichitem).replaceItemPrice(newItemPrice);  	//Display updated price	for (int i=0; i<5; i++)	{	allItems = allItems + item.get(i).getItemValues() +"\n";	}	displayArea.setText(allItems);  	}  	//Changing the quantity of an item  	if (e.getSource() == changeQuantity)	{	int whichitem;	String allItems="";	whichitem = Integer.parseInt(JOptionPane.showInputDialog(null,"Enter the ID of the item to be modified"));	int newItemQuantity = Integer.parseInt(JOptionPane.showInputDialog(null,"Enter the new Quantity"));	item.get(whichitem).replaceItemQuantity(newItemQuantity);  	//Display updated quantity	for (int i=0; i<5; i++)	{	allItems = allItems + item.get(i).getItemValues() +"\n";	}	displayArea.setText(allItems);  	}  	//Vending an item  	if (e.getSource() == purchaseItem){	String Itemname, newidnum,newItm, qtyWanted, allRecords="";	int newPr, qAvailable, rec=0;	boolean found =false;  	Itemname = (JOptionPane.showInputDialog(null, "Enter the item name"));	while(rec<5){	if(Itemname.equals(item.get(rec).getItemName()))	{	found = true;	qtyWanted = (JOptionPane.showInputDialog(null, "Enter amount to vend"));	int QtyOrdered = Integer.valueOf(qtyWanted).intValue();	newidnum = item.get(rec).getItemID();	newItm = item.get(rec).getItemName();	newPr = item.get(rec).getItemPrice();	qAvailable = item.get(rec).getItemQuantity();	int CurrentQ = Integer.valueOf(qAvailable).intValue();	int NewQ = CurrentQ - QtyOrdered;	float P = Float.valueOf(newPr).floatValue();	float TotalPr = P * QtyOrdered;  	if(TotalPr < c.credit)	{	JOptionPane.showMessageDialog(null,"Your bill is "+ TotalPr + "p");	c.credit = c.credit - TotalPr;	String str = "" + c.credit;	creditTextField.setText(str);	item.get(rec).dispenceItem(newidnum, newItm, newPr, NewQ);  	for (int i=0; i<5; i++)	{	allRecords = allRecords + item.get(i).getItemValues() +"\n";	}	displayArea.setText(allRecords);}  	else	{	JOptionPane.showMessageDialog(null,"Insufficient Credit");  	}  	break;	}	rec++;	}	if(found == false){	JOptionPane.showMessageDialog(null, "Item not found, please try again");	}	} } }

Hello AZBOY2000,

What happened with this thread:

http://www.javaprogrammingforums.com...2-classes.html ?

Did my suggestion solve your question or is it still open?

What is the problem with the code you have submitted above? Is it working as expected?

Originally Posted by AZBOY2000

that problem has been solved i think all this thread is about how i want someone else to look through my code and makes sure it works cos i think there is a problem when you order stuff because it keeps refusing to vend items cos it says i dont have enough money even when i have more than enough

I can't get this to add an item.. ?

In the Credit class, you need to change:

[B]private[/B] float credit;

to

[B]public[/B] float credit;

In the Dispenser class, you need to change:

 public void dispenceItem() { if (ItemQuant > 0) ItemQuant = ItemQuant - 1; else { JOptionPane.showMessageDialog(null, "No items left"); } }

to

 public void dispenceItem(String newidnum, String newItm, int newPr, int NewQ) { if (ItemQuant > 0) ItemQuant = ItemQuant - 1; else { JOptionPane.showMessageDialog(null, "No items left"); } }

The dispenceItem() method needs to be able to accept the arguments, String, String, Int, Int.

Originally Posted by AZBOY2000

thanks for all the help so far i just have two problems left and i think there both simple
1. is that when i order stuff it refuses to dispence because it says i dont have enough credit
2 . is that ive forgot what you put so you can change the color of the overall form cos i wana change it from grey to blue

I can't get this code to refuse to dispence an item? It doesn't allow me to add anything and it says my credit is 0. Please tell me what I need to do to see this problem for myself.

Have you tried .setBackground(Color.BLUE); ?