Multi stage Dockerfile for eccode compilation

Instead of a COPY + RUN tar, you can get Docker to do the extraction for you by using ADD, since you have the file downloaded externally anyway:

If <src> is a local tar archive in a recognized compression format (identity, gzip, bzip2 or xz) then it is unpacked as a directory. Resources from remote URLs are not decompressed. When a directory is copied or unpacked, it has the same behavior as tar -x, the result is the union of:

1. Whatever existed at the destination path and
2. The contents of the source tree, with conflicts resolved in favor of "2." on a file-by-file basis.

Note

Whether a file is identified as a recognized compression format or not is done solely based on the contents of the file, not the name of the file. For example, if an empty file happens to end with .tar.gz this will not be recognized as a compressed file and will not generate any kind of decompression error message, rather the file will simply be copied to the destination.

apt-get install -y will not suppress debconf questions (e.g., selecting the local timezone when install the timezone database package). However, since Docker doesn't provide an terminal on which debconf questions can be presented, they'll be automatically answered anyway, but this will lead to more noise in the build log. You should set the environment variable DEBIAN_FRONTEND=noninteractive to suppress debconf questions.

The Docker documentation on ENV has an incorrect example of using DEBIAN_FRONTEND:

If an environment variable is only needed during build, and not in the final image, consider setting a value for a single command instead:

RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y ... 

In this command, DEBIAN_FRONTEND will only affect apt-get update, which won't be asking debconf questions anyway. It should be either:

RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y ... 

Or:

RUN export DEBIAN_FRONTEND=noninteractive; apt-get update && apt-get install -y ... 

RUN commands are run in independent shells and a cd in one wouldn't affect the working directory in another:

Note that each instruction is run independently, and causes a new image to be created - so RUN cd /tmp will not have any effect on the next instructions.

You should use WORKDIR instead, and since it can create the directory if it doesn't exist, skip the mkdir for that directory:

RUN mkdir "$ECCODES_DIR" WORKDIR build RUN cmake ../eccodes-2.24.2-Source -DCMAKE_INSTALL_PREFIX="$ECCODES_DIR" -DENABLE_JPG=ON 

(Also, quote your variables.)

Try to order layers in a way that matches their dependencies. In this snippet, only the last RUN depends on the COPY, but the preceding RUN statements will be re-executed each time requirements.txt changes, even if the cached results are perfectly usable:

COPY ./requirements.txt ./requirements.txt # create the virtual env RUN python3 -m venv $VIRTUAL_ENV # upgrade pip RUN python3 -m pip install --upgrade pip # install the requirements RUN pip install -r requirements.txt 

I'd suggest:

# create the virtual env RUN python3 -m venv "$VIRTUAL_ENV" # upgrade pip RUN python3 -m pip install --upgrade pip COPY ./requirements.txt ./requirements.txt # install the requirements RUN pip install -r requirements.txt 

(Or keep the COPY before upgrading pip. In either case, the virtualenv creation doesn't need to be re-run each time requirements.txt changes.)