Skip to content

[ur_controllers] Remove Werror from CMakeLists (backport #1720)#1727

Merged
urfeex merged 4 commits intohumblefrom
mergify/bp/humble/pr-1720
Mar 27, 2026
Merged

[ur_controllers] Remove Werror from CMakeLists (backport #1720)#1727
urfeex merged 4 commits intohumblefrom
mergify/bp/humble/pr-1720

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Mar 27, 2026

While this might be good for CI reasons, this has broken our buildfarm builds a couple of times over the last years due to upstream warnings.

Removing this from the CMakeLists would not affect buildfarm builds, while we can still enable this in CI if we want.


This is an automatic backport of pull request #1720 done by Mergify.

While this might be good for CI reasons, this has broken our buildfarm builds a couple of times over the last years due to upstream warnings. In CI we want to treat warnings as errors in order to see deprecations more quickly. Right now, adding -Wno-error=cpp is necessary because of upstream raising internal deprecation warnings. (cherry picked from commit 2fb2d5a) # Conflicts: #	.github/workflows/reusable_ici.yml #	ur_controllers/CMakeLists.txt
@mergify mergify bot added conflicts humble Relevant for humble and higher ROS versions labels Mar 27, 2026
@mergify
Copy link
Copy Markdown
Author

mergify bot commented Mar 27, 2026

Cherry-pick of 2fb2d5a has failed:

On branch mergify/bp/humble/pr-1720 Your branch is up to date with 'origin/humble'. You are currently cherry-picking commit 2fb2d5a. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed:	modified: ur_robot_driver/include/ur_robot_driver/hardware_interface.hpp Unmerged paths: (use "git add/rm <file>..." as appropriate to mark resolution)	deleted by us: .github/workflows/reusable_ici.yml	both modified: ur_controllers/CMakeLists.txt 

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@urfeex urfeex removed the conflicts label Mar 27, 2026
@urfeex urfeex merged commit 6effe8a into humble Mar 27, 2026
4 of 7 checks passed
@urfeex urfeex deleted the mergify/bp/humble/pr-1720 branch March 27, 2026 14:03
@urfeex urfeex added the CI label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI humble Relevant for humble and higher ROS versions

1 participant