[ur_controllers] Remove Werror from CMakeLists (backport #1720)#1727
Merged
[ur_controllers] Remove Werror from CMakeLists (backport #1720)#1727
Conversation
While this might be good for CI reasons, this has broken our buildfarm builds a couple of times over the last years due to upstream warnings. In CI we want to treat warnings as errors in order to see deprecations more quickly. Right now, adding -Wno-error=cpp is necessary because of upstream raising internal deprecation warnings. (cherry picked from commit 2fb2d5a) # Conflicts: # .github/workflows/reusable_ici.yml # ur_controllers/CMakeLists.txt
Author
| Cherry-pick of 2fb2d5a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
urfeex approved these changes Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this might be good for CI reasons, this has broken our buildfarm builds a couple of times over the last years due to upstream warnings.
Removing this from the CMakeLists would not affect buildfarm builds, while we can still enable this in CI if we want.
This is an automatic backport of pull request #1720 done by Mergify.