Checking if empty vs not checking at all

Question

My code is finished and i'm trying to optimize it. I was wondering if the following 2 are the same or am I missing something that could potentially cause problems later on?

$this_awardid = !empty($_POST['awardid']) ? $_POST['awardid'] : null; if (empty($this_awardid) ) { ... } elseif (!empty($this_awardid)) { ... }

I've optimized the code like so... I'm assuming that $this_awardid it's NOT empty, so there is no need to verify.. Is this logic correct?

if (empty($this_awardid) ) { ... } else { ... }

There are only two values that empty returns - true or false. So, elseif is redundant. — u_mulder
– u_mulder, Commented Mar 20, 2020 at 14:18

deceze · Accepted Answer · 2020-03-20 14:28:14Z

You are defining $this_awardid right there. It's guaranteed to exist. There's no need to use empty for it at all, since all empty does is suppress error messages for non-existing variables. You want error messages should you find $this_awardid to be non-existent, since that means something's very wrong with your code.

Secondly, if (a) else if (!a) is always redundant; you do not need to test for the inverse of the condition again, that is already contained in the if..else itself.

So, all you need is:

if (!$this_awardid) { ... } else { ... }

Penny Codes · Accepted Answer · 2020-03-20 14:22:59Z

empty returns true or false. So no need for elseif

if (empty($this_awardid) ) { // response here } else { // proceed here }

Hope this helps.

Ja͢ck · Accepted Answer · 2020-03-20 14:27:59Z

$this_awardid = !empty($_POST['awardid']) ? $_POST['awardid'] : null;

At this point in your code, $this_awardid is only assigned a value if the $_POST value present (i.e. not empty), otherwise it's set to null; therefore:

if ($this_awardid) { // the value has something } else { // the value is null }

This works, because !empty() is essentially isset($var) && $var == true

Collectives™ on Stack Overflow

Checking if empty vs not checking at all

3 Answers 3

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Related