Error: Cannot convert parameter 1 from std::string to char*. Confused on why it is giving me this error.

Question

So once again I need some help with this program for class. Maybe its that I'm tired but I can't seem to find the logic error I'm sure I've made here. Here is my code:

#include "Book.h" using namespace std; void add (char*, char*, int); void remove (int&); void list (); int Count; Book Bookshelf [4]; int main () { string In; string N; string A; int Y; int Num; do { cout << "Bookshelf> "; getline(cin, In); if (In.compare("add") == 0) { cout << "Bookshelf> Enter book: "; cin >> N >> A >> Y; add (N,A,Y); } else if (In.compare ("remove") == 0) { cout << "Bookshelf> Select number: "; cin >> Num; remove (Num); } else if (In.compare("list") == 0) { list (); } } while (cin != "quit"); return 0; } void add (string N, string A, int Y) { if (Bookshelf[4].IsEmpty() == false) cout << "Error!" << endl; else { Bookshelf[Count] = Book (N,A,Y); Count++; } cout << "Bookshelf> "; }

The error occurs at the line add(N,A,Y); but for the life of me I can't tell why it is saying that. They both look like std::strings to me. Can anyone explain this to me?

Sergey Kalinichenko · Accepted Answer · 2012-02-11 04:55:04Z

3

You have forgotten to modify your prototype at the top of your file.

It still says

void add (char*, char*, int);

It should be

void add (string, string, int);

answered Feb 11, 2012 at 4:55

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

triple07 Over a year ago

Ah thank you. I can't believe I missed that. Shows what waiting till the last minute to finish does.

Mahesh · Accepted Answer · 2012-02-11 04:55:34Z

You have a wrong forward declaration.

void add (char*, char*, int);

Must be -

void add (string, string, int);

Also, if the array size is N, the accessible indexes are 0 to N-1.

Book Bookshelf [4]; // ..... if (Bookshelf[4].IsEmpty() == false) // There is no object at Bookshelf[4] // Accessible indexes are 0 to 3

Ed Heal · Accepted Answer · 2012-02-11 04:56:48Z

You need to make the declaration match the definition. In the declaration you use char * in the definistion you use string.

If you want to use C strings see c_str. If you want to use strings, remember the '&' to take a reference - saves making a copy. Either way make the prototype and the function signature match.

Collectives™ on Stack Overflow

Error: Cannot convert parameter 1 from std::string to char*. Confused on why it is giving me this error.

3 Answers 3

1 Comment

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Linked

Related