Don't render meshes that have prepass disabled to the prepass, even if they have shadows enabled. #21961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
they have shadows enabled. Currently, the `specialize_prepass_material_meshes` function adds meshes to the prepass unless both `prepass_enabled` *and* `shadows_enabled` are false for that material. This seems incorrect, as (1) the flags are separate for a reason and (2) meshes are added to the shadow pass not in `specialize_prepass_material_meshes` but in `specialize_shadows`. This patch changes `specialize_prepass_material_meshes` to skip adding meshes to the prepass if `prepass_enabled` is false, even if `shadows_enabled` is true.
IceSentry approved these changes Nov 28, 2025
Contributor
IceSentry left a comment
IceSentry left a comment There was a problem hiding this comment.
A part of me is wondering if it should maybe be a || instead of completely removing it but it seemed to work fine in the couple of test I did and it make sense to always skip it when the prepass is enabled.
alice-i-cecile added C-Bug 
mockersf approved these changes Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, the
specialize_prepass_material_meshesfunction adds meshes to the prepass unless bothprepass_enabledandshadows_enabledare false for that material. This seems incorrect, as (1) the flags are separate for a reason and (2) meshes are added to the shadow pass not inspecialize_prepass_material_meshesbut inspecialize_shadows.This patch changes
specialize_prepass_material_meshesto skip adding meshes to the prepass ifprepass_enabledis false, even ifshadows_enabledis true.