integration test incorrect interpreter behavior #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kinto0 added a commit to kinto0/pyrefly that referenced this pull request Dec 2, 2025
Summary: interpreter fails to update type errors when changing from a bad one to a good one reported here facebook#1632 Differential Revision: D87664939
kinto0 added a commit to kinto0/pyrefly that referenced this pull request Dec 2, 2025
Summary: interpreter fails to update type errors when changing from a bad one to a good one reported here facebook#1632 Differential Revision: D87664939
kinto0 added a commit to kinto0/pyrefly that referenced this pull request Dec 2, 2025
Summary: interpreter fails to update type errors when changing from a bad one to a good one reported here facebook#1632 Differential Revision: D87664939
kinto0 force-pushed the export-D87664939 branch 2 times, most recently from 15bc26c to 3bc9ec3 Compare 
… RecheckFinished events (facebook#1730) Summary: The test_notebook_publish_diagnostics test was flaky due to a race condition during LSP initialization. When a client responded to the WorkspaceConfiguration request during initialization, workspace_configuration_response() would trigger invalidate_config_and_validate_in_memory(), which always queued a RecheckFinished event. This RecheckFinished event calls validate_in_memory_and_commit_if_possible(), publishing diagnostics for all currently open files. It seemed like the race occurred because: - If didOpen was processed BEFORE RecheckFinished: The notebook was already in open_files, so RecheckFinished published diagnostics for it → 2 publishDiagnostics (test passed) - If didOpen was processed AFTER RecheckFinished: No files were open yet, so RecheckFinished published nothing → 1 publishDiagnostics (test failed) The fix prevents RecheckFinished from being queued when there are no open files to revalidate. This makes the server behavior deterministic and eliminates the race condition. As a side benefit, this also improves performance by avoiding unnecessary revalidation work during initialization. Differential Revision: D88116232
Summary: interpreter fails to update type errors when changing from a bad one to a good one reported here facebook#1632 Differential Revision: D87664939
kinto0 force-pushed the export-D87664939 branch from 3bc9ec3 to 63263be Compare kinto0 added a commit to kinto0/pyrefly that referenced this pull request Dec 2, 2025
Summary: interpreter fails to update type errors when changing from a bad one to a good one reported here facebook#1632 Differential Revision: D87664939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary:
interpreter fails to update type errors when changing from a bad one to a good one
reported here #1632
Differential Revision: D87664939