This repository was archived by the owner on Jan 25, 2024. It is now read-only.
Zcash: add setConsensusBranchId() to TansactionBuilder#89
Closed
matthewzipkin-bitgo wants to merge 4 commits intomasterfrom
Closed
Zcash: add setConsensusBranchId() to TansactionBuilder#89matthewzipkin-bitgo wants to merge 4 commits intomasterfrom
matthewzipkin-bitgo wants to merge 4 commits intomasterfrom
Conversation
matthewzipkin-bitgo requested review from OttoAllmendinger and argjv as code owners 
daira reviewed Oct 16, 2020
matthewzipkin-bitgo force-pushed the BG-24753-ZEC-consensus-branch-id branch from 8f61bc1 to 14bc607 Compare 
Author
| @OttoAllmendinger @argjv this is ready for review and release -- with at least a minor version bump so consuming applications don't accidentally use the new value before the hard fork activates on mainnet. I'll work on updating those modules now. |
matthewzipkin-bitgo force-pushed the BG-24753-ZEC-consensus-branch-id branch 2 times, most recently from 7434dc4 to cd7d578 Compare Author
| Moving this to #90 to rebase on v1.7.1 |
OttoAllmendinger force-pushed the BG-24753-ZEC-consensus-branch-id branch from cd7d578 to 7434dc4 Compare 
Also including README in test directory to explain how to generate test vectors for the NEXT upgrade TICKET BG-24753
OttoAllmendinger force-pushed the BG-24753-ZEC-consensus-branch-id branch from 7434dc4 to 84e00ee Compare 
Contributor
| reopening this in order to fix reset this to 7434dc4 (before 1.7.x rebase), added my signatures and pushed again |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setConsensusBranchIdas property toTransactionsetConsensusBranchId()to maintain test success with old transaction version (from "Heartwood" fork)TODO:
setConsensusBranchId()with Heartwood value until the day of the hard forkTICKET BG-24753