Zcash: add setConsensusBranchId() to TansactionBuilder#90
Conversation
matthewzipkin-bitgo changed the base branch from v1.7.1 to BG-22830-update-zec-heartwood matthewzipkin-bitgo changed the title Also including README in test directory to explain how to generate test vectors for the NEXT upgrade TICKET BG-24753
matthewzipkin-bitgo force-pushed the BG-24753-ZEC-consensus-branch-id-rebase-1.7.1 branch from cd7d578 to 6e7ba05 Compare 
argjv left a comment
argjv left a comment There was a problem hiding this comment.
Update package.json version and LGTM
| Ok thanks - still making sure it runs correctly as a dep to wallet-platform. Once I'm confident it works I'll come back and merge. Also should we call this version |
OttoAllmendinger left a comment
OttoAllmendinger left a comment There was a problem hiding this comment.
so this only affects how we are building new zcash txs, not how existing ones are parsed?
| @@ -0,0 +1,126 @@ | |||
| # Generate test vectors for new ZCash testnet consensus branch IDs | |||
There was a problem hiding this comment.
awesome!
long-term we should have a script for this, but we can tackle that when we overhaul this lib
| the fact that this changes the default way zcash transactions are built actually suggests we bump the minor version Alternatively we could instead release a version of this lib that supports the new consensusBranchId in a convenient way without defaulting to it. That way we can decide at the callsite somehow. |
OttoAllmendinger left a comment
OttoAllmendinger left a comment There was a problem hiding this comment.
Actually I realized that this is for an old version. New development should happen on the master branch.
| We are releasing 1.7.2 because the latest version in master breaks platform and other places. Fixing utxo-lib is not in the roadmap. |
3 participants
#89 but rebased on v1.7.1
TICKET BG-24753