Add vertx postgresql client instrumentation #8471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vandonr added type: enhancement 
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~4af5e17928, baseline=1.48.0-SNAPSHOT~b34cd6dbd9 dateFormat X axisFormat %s section tracing Agent [baseline] (1.047 s) : 0, 1046533 Total [baseline] (10.472 s) : 0, 10472242 Agent [candidate] (1.042 s) : 0, 1041642 Total [candidate] (10.415 s) : 0, 10414771 section appsec Agent [baseline] (1.187 s) : 0, 1187329 Total [baseline] (10.789 s) : 0, 10789389 Agent [candidate] (1.192 s) : 0, 1191851 Total [candidate] (10.749 s) : 0, 10749128 section iast Agent [baseline] (1.172 s) : 0, 1171958 Total [baseline] (11.028 s) : 0, 11027587 Agent [candidate] (1.178 s) : 0, 1178403 Total [candidate] (10.966 s) : 0, 10965884 section profiling Agent [baseline] (1.263 s) : 0, 1262822 Total [baseline] (10.877 s) : 0, 10876567 Agent [candidate] (1.259 s) : 0, 1258871 Total [candidate] (10.833 s) : 0, 10832837
gantt title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~4af5e17928, baseline=1.48.0-SNAPSHOT~b34cd6dbd9 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (721.386 ms) : 0, 721386 BytebuddyAgent [candidate] (717.693 ms) : 0, 717693 GlobalTracer [baseline] (240.689 ms) : 0, 240689 GlobalTracer [candidate] (239.931 ms) : 0, 239931 AppSec [baseline] (55.846 ms) : 0, 55846 AppSec [candidate] (55.406 ms) : 0, 55406 Remote Config [baseline] (700.166 µs) : 0, 700 Remote Config [candidate] (692.856 µs) : 0, 693 Telemetry [baseline] (12.893 ms) : 0, 12893 Telemetry [candidate] (12.965 ms) : 0, 12965 section appsec BytebuddyAgent [baseline] (737.423 ms) : 0, 737423 BytebuddyAgent [candidate] (741.579 ms) : 0, 741579 GlobalTracer [baseline] (237.692 ms) : 0, 237692 GlobalTracer [candidate] (238.135 ms) : 0, 238135 IAST [baseline] (21.736 ms) : 0, 21736 IAST [candidate] (21.498 ms) : 0, 21498 AppSec [baseline] (177.378 ms) : 0, 177378 AppSec [candidate] (177.329 ms) : 0, 177329 Remote Config [baseline] (666.033 µs) : 0, 666 Remote Config [candidate] (674.262 µs) : 0, 674 Telemetry [baseline] (8.356 ms) : 0, 8356 Telemetry [candidate] (8.331 ms) : 0, 8331 section iast BytebuddyAgent [baseline] (837.307 ms) : 0, 837307 BytebuddyAgent [candidate] (844.032 ms) : 0, 844032 GlobalTracer [baseline] (230.618 ms) : 0, 230618 GlobalTracer [candidate] (230.636 ms) : 0, 230636 IAST [baseline] (22.954 ms) : 0, 22954 IAST [candidate] (22.908 ms) : 0, 22908 AppSec [baseline] (56.807 ms) : 0, 56807 AppSec [candidate] (56.37 ms) : 0, 56370 Remote Config [baseline] (614.487 µs) : 0, 614 Remote Config [candidate] (617.628 µs) : 0, 618 Telemetry [baseline] (8.692 ms) : 0, 8692 Telemetry [candidate] (8.697 ms) : 0, 8697 section profiling BytebuddyAgent [baseline] (710.476 ms) : 0, 710476 BytebuddyAgent [candidate] (708.416 ms) : 0, 708416 GlobalTracer [baseline] (350.26 ms) : 0, 350260 GlobalTracer [candidate] (350.369 ms) : 0, 350369 AppSec [baseline] (55.323 ms) : 0, 55323 AppSec [candidate] (53.907 ms) : 0, 53907 Remote Config [baseline] (680.995 µs) : 0, 681 Remote Config [candidate] (669.252 µs) : 0, 669 Telemetry [baseline] (9.005 ms) : 0, 9005 Telemetry [candidate] (8.956 ms) : 0, 8956 ProfilingAgent [baseline] (96.627 ms) : 0, 96627 ProfilingAgent [candidate] (96.193 ms) : 0, 96193 Profiling [baseline] (96.652 ms) : 0, 96652 Profiling [candidate] (96.218 ms) : 0, 96218 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~4af5e17928, baseline=1.48.0-SNAPSHOT~b34cd6dbd9 dateFormat X axisFormat %s section tracing Agent [baseline] (1.046 s) : 0, 1046292 Total [baseline] (8.688 s) : 0, 8687959 Agent [candidate] (1.039 s) : 0, 1038841 Total [candidate] (8.662 s) : 0, 8662288 section iast Agent [baseline] (1.171 s) : 0, 1170549 Total [baseline] (9.264 s) : 0, 9263689 Agent [candidate] (1.169 s) : 0, 1169087 Total [candidate] (9.239 s) : 0, 9238615 section iast_HARDCODED_SECRET_DISABLED Agent [baseline] (1.168 s) : 0, 1168179 Total [baseline] (9.193 s) : 0, 9192712 Agent [candidate] (1.172 s) : 0, 1172436 Total [candidate] (9.194 s) : 0, 9194057 section iast_TELEMETRY_OFF Agent [baseline] (1.171 s) : 0, 1170551 Total [baseline] (9.275 s) : 0, 9274650 Agent [candidate] (1.165 s) : 0, 1165114 Total [candidate] (9.244 s) : 0, 9243624
gantt title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~4af5e17928, baseline=1.48.0-SNAPSHOT~b34cd6dbd9 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (721.335 ms) : 0, 721335 BytebuddyAgent [candidate] (717.015 ms) : 0, 717015 GlobalTracer [baseline] (240.539 ms) : 0, 240539 GlobalTracer [candidate] (239.396 ms) : 0, 239396 AppSec [baseline] (55.654 ms) : 0, 55654 AppSec [candidate] (55.431 ms) : 0, 55431 Remote Config [baseline] (701.639 µs) : 0, 702 Remote Config [candidate] (688.53 µs) : 0, 689 Telemetry [baseline] (13.063 ms) : 0, 13063 Telemetry [candidate] (11.386 ms) : 0, 11386 section iast BytebuddyAgent [baseline] (836.365 ms) : 0, 836364 BytebuddyAgent [candidate] (835.374 ms) : 0, 835374 GlobalTracer [baseline] (230.453 ms) : 0, 230453 GlobalTracer [candidate] (229.821 ms) : 0, 229821 IAST [baseline] (23.629 ms) : 0, 23629 IAST [candidate] (22.94 ms) : 0, 22940 AppSec [baseline] (55.871 ms) : 0, 55871 AppSec [candidate] (56.654 ms) : 0, 56654 Remote Config [baseline] (609.51 µs) : 0, 610 Remote Config [candidate] (609.177 µs) : 0, 609 Telemetry [baseline] (8.664 ms) : 0, 8664 Telemetry [candidate] (8.736 ms) : 0, 8736 section iast_HARDCODED_SECRET_DISABLED BytebuddyAgent [baseline] (834.906 ms) : 0, 834906 BytebuddyAgent [candidate] (837.016 ms) : 0, 837016 GlobalTracer [baseline] (230.048 ms) : 0, 230048 GlobalTracer [candidate] (231.043 ms) : 0, 231043 IAST [baseline] (23.511 ms) : 0, 23511 IAST [candidate] (23.023 ms) : 0, 23023 AppSec [baseline] (55.572 ms) : 0, 55572 AppSec [candidate] (56.995 ms) : 0, 56995 Remote Config [baseline] (600.873 µs) : 0, 601 Remote Config [candidate] (617.906 µs) : 0, 618 Telemetry [baseline] (8.639 ms) : 0, 8639 Telemetry [candidate] (8.75 ms) : 0, 8750 section iast_TELEMETRY_OFF BytebuddyAgent [baseline] (835.851 ms) : 0, 835851 BytebuddyAgent [candidate] (831.728 ms) : 0, 831728 GlobalTracer [baseline] (230.822 ms) : 0, 230822 GlobalTracer [candidate] (230.31 ms) : 0, 230310 IAST [baseline] (22.42 ms) : 0, 22420 IAST [candidate] (23.227 ms) : 0, 23227 AppSec [baseline] (57.17 ms) : 0, 57170 AppSec [candidate] (55.693 ms) : 0, 55693 Remote Config [baseline] (619.192 µs) : 0, 619 Remote Config [candidate] (608.762 µs) : 0, 609 Telemetry [baseline] (8.733 ms) : 0, 8733 Telemetry [candidate] (8.565 ms) : 0, 8565 LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~4af5e17928, baseline=1.48.0-SNAPSHOT~b34cd6dbd9 dateFormat X axisFormat %s section baseline no_agent (379.282 µs) : 359, 399 . : milestone, 379, iast (507.395 µs) : 485, 529 . : milestone, 507, iast_FULL (726.693 µs) : 705, 749 . : milestone, 727, iast_GLOBAL (559.987 µs) : 537, 583 . : milestone, 560, iast_HARDCODED_SECRET_DISABLED (503.242 µs) : 482, 525 . : milestone, 503, iast_INACTIVE (461.45 µs) : 439, 484 . : milestone, 461, iast_TELEMETRY_OFF (496.19 µs) : 473, 519 . : milestone, 496, tracing (453.094 µs) : 432, 474 . : milestone, 453, section candidate no_agent (376.203 µs) : 356, 397 . : milestone, 376, iast (505.307 µs) : 484, 527 . : milestone, 505, iast_FULL (723.597 µs) : 702, 745 . : milestone, 724, iast_GLOBAL (559.82 µs) : 537, 583 . : milestone, 560, iast_HARDCODED_SECRET_DISABLED (511.937 µs) : 490, 534 . : milestone, 512, iast_INACTIVE (454.79 µs) : 434, 476 . : milestone, 455, iast_TELEMETRY_OFF (495.453 µs) : 473, 518 . : milestone, 495, tracing (459.014 µs) : 437, 481 . : milestone, 459,
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~4af5e17928, baseline=1.48.0-SNAPSHOT~b34cd6dbd9 dateFormat X axisFormat %s section baseline no_agent (1.353 ms) : 1333, 1372 . : milestone, 1353, appsec (1.715 ms) : 1691, 1738 . : milestone, 1715, appsec_no_iast (1.727 ms) : 1703, 1752 . : milestone, 1727, code_origins (1.666 ms) : 1632, 1700 . : milestone, 1666, iast (1.498 ms) : 1473, 1522 . : milestone, 1498, profiling (1.521 ms) : 1497, 1544 . : milestone, 1521, tracing (1.5 ms) : 1476, 1525 . : milestone, 1500, section candidate no_agent (1.356 ms) : 1335, 1376 . : milestone, 1356, appsec (1.719 ms) : 1695, 1743 . : milestone, 1719, appsec_no_iast (1.722 ms) : 1697, 1748 . : milestone, 1722, code_origins (1.688 ms) : 1655, 1720 . : milestone, 1688, iast (1.504 ms) : 1479, 1529 . : milestone, 1504, profiling (1.493 ms) : 1469, 1517 . : milestone, 1493, tracing (1.509 ms) : 1485, 1533 . : milestone, 1509,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~4af5e17928, baseline=1.48.0-SNAPSHOT~b34cd6dbd9 dateFormat X axisFormat %s section baseline no_agent (14.891 s) : 14891000, 14891000 . : milestone, 14891000, appsec (15.252 s) : 15252000, 15252000 . : milestone, 15252000, iast (18.815 s) : 18815000, 18815000 . : milestone, 18815000, iast_GLOBAL (17.749 s) : 17749000, 17749000 . : milestone, 17749000, profiling (14.996 s) : 14996000, 14996000 . : milestone, 14996000, tracing (15.239 s) : 15239000, 15239000 . : milestone, 15239000, section candidate no_agent (15.616 s) : 15616000, 15616000 . : milestone, 15616000, appsec (14.947 s) : 14947000, 14947000 . : milestone, 14947000, iast (18.646 s) : 18646000, 18646000 . : milestone, 18646000, iast_GLOBAL (18.248 s) : 18248000, 18248000 . : milestone, 18248000, profiling (14.861 s) : 14861000, 14861000 . : milestone, 14861000, tracing (15.171 s) : 15171000, 15171000 . : milestone, 15171000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~4af5e17928, baseline=1.48.0-SNAPSHOT~b34cd6dbd9 dateFormat X axisFormat %s section baseline no_agent (1.481 ms) : 1470, 1493 . : milestone, 1481, appsec (2.344 ms) : 2301, 2387 . : milestone, 2344, iast (2.127 ms) : 2072, 2181 . : milestone, 2127, iast_GLOBAL (2.166 ms) : 2111, 2222 . : milestone, 2166, profiling (1.967 ms) : 1924, 2010 . : milestone, 1967, tracing (1.967 ms) : 1925, 2009 . : milestone, 1967, section candidate no_agent (1.48 ms) : 1468, 1491 . : milestone, 1480, appsec (2.352 ms) : 2308, 2395 . : milestone, 2352, iast (2.125 ms) : 2070, 2180 . : milestone, 2125, iast_GLOBAL (2.179 ms) : 2124, 2235 . : milestone, 2179, profiling (2.007 ms) : 1961, 2052 . : milestone, 2007, tracing (1.958 ms) : 1916, 2000 . : milestone, 1958,
|
Contributor
| @vandonr @amarziali any update on code review for this PR? |
Contributor Author
| the CI is red because there is an issue with the latest version(s). Somehow the dbInfo is not populated correctly, so the operation name takes the default value instead of the expected one. I need to debug what is happening, and either fix it or restrict the range to the max version that would work. |
amarziali approved these changes Mar 7, 2025
Contributor
amarziali left a comment
amarziali left a comment There was a problem hiding this comment.
LGTM. I had to change few things:
- Refactor the common (thank for the initial refactoring) to include also the prepared statement advices since they work all along the versions
- Change the name of common to vertx-sql-client-3.9 to comply with our standards
- Simplify muzzle checks and add one for the common module
- Add more test fuzziness to check interaction between vertx mysql and pgsql modules
It looks OK to go for my standpoint. Since I also added a commit I will ask for another quick review before merging
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Apr 11, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | org.flywaydb.flyway | plugin | misk/gradle/libs.versions.toml | gradle | minor | `11.6.0` -> `11.7.0` | | [com.squareup.okio:okio-fakefilesystem](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.10.2` -> `3.11.0` | | [com.squareup.okio:okio](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.10.2` -> `3.11.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | minor | `2.15.0` -> `2.16.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.47.3` -> `1.48.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.47.3` -> `1.48.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | --- ### Release Notes <details> <summary>square/okio (com.squareup.okio:okio-fakefilesystem)</summary> ### [`v3.11.0`](https://github.com/square/okio/blob/HEAD/CHANGELOG.md#Version-3110) *2025-04-09* - Fix: Clear the deflater's byte array reference - New: Faster implementation of `String.decodeHex()` on Kotlin/JS. - New: Declare `EXACTLY_ONCE` execution for blocks like `Closeable.use {}` and `FileSystem.read {}`. - Upgrade: \[Kotlin 2.1.20]\[kotlin\_2\_1\_20]. </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.16.0`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-2160) - \[Feat]: support `com.android.test` projects. - \[Feat]: support typesafe project accessors with opt-in. ```kotlin dependencyAnalysis { useTypesafeProjectAccessors(true) // false by default } ``` </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.48.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.1): 1.48.1 ### Components #### Tracer internal logging - 🐛 Remove print line causing unnecessary logs ([#​8687](DataDog/dd-trace-java#8687) - [@​sarahchen6](https://github.com/sarahchen6)) ### [`v1.48.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.0): 1.48.0 ### Known Bugs > \[!NOTE] > If you are experiencing issues with spamming timeout logs, please update to the [latest version](https://github.com/DataDog/dd-trace-java/releases/latest) or set [JDK_SOCKET_ENABLED](https://github.com/DataDog/dd-trace-java/blob/33fc3c9a9b7cda3beda88b8b3e5224ae2b10764a/dd-trace-api/src/main/java/datadog/trace/api/config/GeneralConfig.java#L98) to false. ### Components #### Application Security Management (IAST) - ✨ Fix vulnerability location org.jose4j.lang.HashUtil ([#​8610](DataDog/dd-trace-java#8610) - [@​jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness in oracle.ucp.util.OpaqueString ([#​8609](DataDog/dd-trace-java#8609) - [@​jandro996](https://github.com/jandro996)) - ✨ Fix weak hash false positive in oracle.security.o5logon.O5Logon ([#​8608](DataDog/dd-trace-java#8608) - [@​jandro996](https://github.com/jandro996)) - 🐛 Prevent before callsites targeting constructors in super calls ([#​8549](DataDog/dd-trace-java#8549) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Application Security Management (WAF) - ✨ Update login events public SDK to V2 ([#​8620](DataDog/dd-trace-java#8620) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Send RASP LFI capability only when AppSec is statically enabled ([#​8573](DataDog/dd-trace-java#8573) - [@​jandro996](https://github.com/jandro996)) - ✨ Improve detection of missing request end events ([#​8510](DataDog/dd-trace-java#8510) - [@​smola](https://github.com/smola)) - 🧹 Remove remote configuration for API Security sampling rate ([#​8486](DataDog/dd-trace-java#8486) - [@​smola](https://github.com/smola)) - ✨ Add setUser to user monitoring SDK ([#​8482](DataDog/dd-trace-java#8482) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add missing address for signup event ([#​8469](DataDog/dd-trace-java#8469) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Allow login events SDK to be used with appsec disabled ([#​8464](DataDog/dd-trace-java#8464) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for endpoint discovery in spring mvc ([#​8352](DataDog/dd-trace-java#8352) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ New API Security sampling algorithm ([#​8178](DataDog/dd-trace-java#8178) - [@​ValentinZakharov](https://github.com/ValentinZakharov)) #### Build & Tooling - ✨ Add buffer size customizability to JDK UDS support ([#​8629](DataDog/dd-trace-java#8629) - [@​sarahchen6](https://github.com/sarahchen6)) - ✨ Add JDK built-in support for UDS on Java 16+ ([#​8314](DataDog/dd-trace-java#8314) - [@​sarahchen6](https://github.com/sarahchen6)) #### Configuration at Runtime - 🐛 Send RASP LFI capability only when AppSec is statically enabled ([#​8573](DataDog/dd-trace-java#8573) - [@​jandro996](https://github.com/jandro996)) #### Continuous Integration Visibility - 🐛 Prevent double reporting of Scalatest events when using SBT with test forking ([#​8682](DataDog/dd-trace-java#8682) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Shutdown CI Visibility test event handlers before tracer ([#​8677](DataDog/dd-trace-java#8677) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Do not apply JUnit 4 instrumentation to MUnit runners ([#​8675](DataDog/dd-trace-java#8675), [#​8683](DataDog/dd-trace-java#8683) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Remove error log when source path resolution fails on isModified check ([#​8663](DataDog/dd-trace-java#8663) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement tests reordering for JUnit 4 ([#​8650](DataDog/dd-trace-java#8650) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Set default Attempt to Fix retries if none provided from the backend ([#​8615](DataDog/dd-trace-java#8615) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Allow to manually set PR info ([#​8566](DataDog/dd-trace-java#8566) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Test Optimization init when repo root cannot be determined ([#​8533](DataDog/dd-trace-java#8533) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add capabilities tagging ([#​8499](DataDog/dd-trace-java#8499), [#​8540](DataDog/dd-trace-java#8540) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Crash tracking - 🐛 Remove dependency on bash from crash/oome uploder scripts ([#​8652](DataDog/dd-trace-java#8652) - [@​jbachorik](https://github.com/jbachorik)) #### Data Streams Monitoring - ✨ e2e pipeline configuration when data jobs is enabled ([#​8553](DataDog/dd-trace-java#8553) - [@​kr-igor](https://github.com/kr-igor)) #### Dynamic Instrumentation - 🐛 Fix In-Product when config is empty ([#​8679](DataDog/dd-trace-java#8679) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add support for filtering shaded third-party libs ([#​8612](DataDog/dd-trace-java#8612) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add In-Product Enablement ([#​8587](DataDog/dd-trace-java#8587) - [@​jpbempel](https://github.com/jpbempel)) - ✨⚡ Reduce footprint of SourceFile tracking ([#​8524](DataDog/dd-trace-java#8524) - [@​jpbempel](https://github.com/jpbempel)) - ✨⚡ Optimize the SourceFile tracking ([#​8520](DataDog/dd-trace-java#8520) - [@​jpbempel](https://github.com/jpbempel)) #### OpenTracing - 🧹 Remove activeScope() use in OpenTracing shim ([#​8478](DataDog/dd-trace-java#8478) - [@​mcculls](https://github.com/mcculls)) #### Profiling - ✨ Add profiler env check command to AgentCLI ([#​8671](DataDog/dd-trace-java#8671) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.23.0 ([#​8668](DataDog/dd-trace-java#8668) - [@​jbachorik](https://github.com/jbachorik)) - Fix a crash related to ElfParser::loadSymbolTable ([#​191](DataDog/dd-trace-java#191)) by [@​yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#192 - Unwind String.indexOf intrinsic on AArch64 by [@​MattAlp](https://github.com/MattAlp) in DataDog/java-profiler#193 - Fix Java 24 support by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#194 - A set of fixes related to clang, aarch64 and musl pecularities of vmstructs stack unwinder by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#199 - 🐛 Remove process information from JFR recording ([#​8661](DataDog/dd-trace-java#8661) - [@​r1viollet](https://github.com/r1viollet)) - 🐛 Make TempLocationManager USER aware ([#​8605](DataDog/dd-trace-java#8605) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Extract git tags from embedded git.properties and datadog_git.properties ([#​8561](DataDog/dd-trace-java#8561) - [@​wmouchere](https://github.com/wmouchere)) #### Telemetry - 🐛 Fix appsec.rasp.error and appsec.waf.error telemetry metrics ([#​8624](DataDog/dd-trace-java#8624) - [@​jandro996](https://github.com/jandro996)) - ✨ Create metric: appsec.rasp.rule.skipped ([#​8618](DataDog/dd-trace-java#8618) - [@​jandro996](https://github.com/jandro996)) - ✨ Extract git tags from embedded git.properties and datadog_git.properties ([#​8561](DataDog/dd-trace-java#8561) - [@​wmouchere](https://github.com/wmouchere)) #### Testing - 🧹 Simplify ssi tests one-pipeline ([#​8558](DataDog/dd-trace-java#8558) - [@​robertomonteromiguel](https://github.com/robertomonteromiguel)) - ✨ Add smoke tests for java's concurrent API ([#​8438](DataDog/dd-trace-java#8438) - [@​sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - ✨ Adding Support for `TRACE_PROPAGATION_BEHAVIOR_EXTRACT` ([#​8535](DataDog/dd-trace-java#8535) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer core - 🐛 Ensure shaded helpers have unique names ([#​8559](DataDog/dd-trace-java#8559) - [@​amarziali](https://github.com/amarziali)) - ✨ Support common config sources for user-provided git info ([#​8547](DataDog/dd-trace-java#8547) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Make the default config sources more robust when a security manager is installed ([#​8544](DataDog/dd-trace-java#8544) - [@​mcculls](https://github.com/mcculls)) - ✨ Support targeting services with configurations in stable configuration file ([#​8526](DataDog/dd-trace-java#8526) - [@​mtoffl01](https://github.com/mtoffl01)) - ✨ Add new parser for `DD_TAGS` and prioritizing `DD_SERVICE` ([#​8296](DataDog/dd-trace-java#8296) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer internal logging - 🐛 Add missing debug log for the cloudPayloadTaggingServices config ([#​8600](DataDog/dd-trace-java#8600) - [@​ygree](https://github.com/ygree)) - ✨ Add the possibility to output the logs of the Java tracer in JSON ([#​8083](DataDog/dd-trace-java#8083) - [@​cecile75](https://github.com/cecile75)) #### Tracer public API - ✨ Introducing `DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED` Config ([#​8536](DataDog/dd-trace-java#8536) - [@​mhlidd](https://github.com/mhlidd)) - ✨ Config Consistency Round 2 ([#​8489](DataDog/dd-trace-java#8489) - [@​mhlidd](https://github.com/mhlidd)) ### Instrumentations #### - 🐛 Fix NPE in getMdcCopy of LoggingEventInstrumentation ([#​8599](DataDog/dd-trace-java#8599) - [@​ygree](https://github.com/ygree)) #### Apache Spark instrumentation - ✨ Instrument Runtime.exit() to finish spark application spans ([#​8572](DataDog/dd-trace-java#8572) - [@​paul-laffon-dd](https://github.com/paul-laffon-dd)) - ✨ Configure OpenLineage if present in Spark instrumentation ([#​8541](DataDog/dd-trace-java#8541) - [@​mobuchowski](https://github.com/mobuchowski)) #### Armeria Instrumentation - ✨ Support armeria grpc 1.32.3 ([#​8606](DataDog/dd-trace-java#8606) - [@​github-actions](https://github.com/github-actions)\[bot]) #### AWS DynamoDB Instrumentation - ✨ Create DynamoDB instrumentation + add span pointers for `updateItem` and `deleteItem` ([#​8490](DataDog/dd-trace-java#8490) - [@​nhulston](https://github.com/nhulston)) #### AWS SDK instrumentation - ✨ Add DynamoDB in DEFAULT_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES ([#​8595](DataDog/dd-trace-java#8595) - [@​joeyzhao2018](https://github.com/joeyzhao2018)) #### Azure Functions instrumentation - ✨ Enable tracer computed trace metrics by default for Azure Functions ([#​8518](DataDog/dd-trace-java#8518) - [@​duncanpharvey](https://github.com/duncanpharvey)) - 💡 Add azure-functions instrumentation ([#​8432](DataDog/dd-trace-java#8432) - [@​duncanpharvey](https://github.com/duncanpharvey)) #### Core Java language instrumentation - 🐛 Fix ForkJoinPool.execute() instrumentation on Java 21+ ([#​8560](DataDog/dd-trace-java#8560) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Eclipse Vert.x instrumentation - ✨ Add vertx postgresql client instrumentation ([#​8471](DataDog/dd-trace-java#8471) - [@​vandonr](https://github.com/vandonr) - thanks for the contribution!) #### Kafka instrumentation - ✨ Support and test kafka-clients 4 ([#​8581](DataDog/dd-trace-java#8581) - [@​amarziali](https://github.com/amarziali)) #### Kotlin instrumentation - ✨ Avoid disconnected traces when using Kotlin flowOn ([#​8651](DataDog/dd-trace-java#8651) - [@​mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🧹 Migrate OtelContext wrapper to new internal Context API ([#​8645](DataDog/dd-trace-java#8645) - [@​mcculls](https://github.com/mcculls)) #### Spring instrumentation - 🐛 Support CompletableFuture on spring webmvc controllers ([#​8659](DataDog/dd-trace-java#8659) - [@​amarziali](https://github.com/amarziali)) - ✨ Add support for endpoint discovery in spring mvc ([#​8352](DataDog/dd-trace-java#8352) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### WebSocket Instrumentation - ✨ Instrument Jetty websocket pojo ([#​8562](DataDog/dd-trace-java#8562) - [@​amarziali](https://github.com/amarziali)) - 💡 Instrument Java Websocket API (JSR356) ([#​8440](DataDog/dd-trace-java#8440) - [@​amarziali](https://github.com/amarziali)) #### All other instrumentations - ✨ Introduce cache for peer.hostname lookup ([#​8601](DataDog/dd-trace-java#8601) - [@​mcculls](https://github.com/mcculls)) - ✨ Support pekko http 1.1 ([#​8532](DataDog/dd-trace-java#8532) - [@​amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 331314f71acaced3adc75ea5d7e855c248d593fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
copy from #8457 so that I own the branch and CI can run happily
What Does This Do
This PR adds support for automatic tracing of PostgreSQL queries when using the Vert.x PostgreSQL Client in a Vert.x 4 application, enabling Datadog APM to capture query execution times and database interactions.
Motivation
Datadog APM currently doesn't automatically trace PostgreSQL queries executed via the Vert.x PostgreSQL Client, leading to a lack of visibility into database operations. This fix addresses that gap.
Additional Notes
The PR ensures that PostgreSQL queries are automatically instrumented and visible in Datadog APM.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issuecloses #8455