Do not apply JUnit 4 instrumentation to MUnit runners #8675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog added type: bug 
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 68 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~9fe9944f89, baseline=1.48.0-SNAPSHOT~295a700744 dateFormat X axisFormat %s section tracing Agent [baseline] (1.065 s) : 0, 1065237 Total [baseline] (8.702 s) : 0, 8701939 Agent [candidate] (1.074 s) : 0, 1073645 Total [candidate] (8.712 s) : 0, 8712444 section iast Agent [baseline] (1.194 s) : 0, 1194226 Total [baseline] (9.275 s) : 0, 9274526 Agent [candidate] (1.184 s) : 0, 1183978 Total [candidate] (9.269 s) : 0, 9268632 section iast_HARDCODED_SECRET_DISABLED Agent [baseline] (1.19 s) : 0, 1189779 Total [baseline] (9.216 s) : 0, 9215941 Agent [candidate] (1.204 s) : 0, 1204152 Total [candidate] (9.281 s) : 0, 9281341 section iast_TELEMETRY_OFF Agent [baseline] (1.189 s) : 0, 1189261 Total [baseline] (9.337 s) : 0, 9337147 Agent [candidate] (1.181 s) : 0, 1181147 Total [candidate] (9.262 s) : 0, 9262286
gantt title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~9fe9944f89, baseline=1.48.0-SNAPSHOT~295a700744 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (727.46 ms) : 0, 727460 BytebuddyAgent [candidate] (733.487 ms) : 0, 733487 GlobalTracer [baseline] (241.518 ms) : 0, 241518 GlobalTracer [candidate] (243.255 ms) : 0, 243255 AppSec [baseline] (55.002 ms) : 0, 55002 AppSec [candidate] (55.648 ms) : 0, 55648 Debugger [baseline] (4.42 ms) : 0, 4420 Debugger [candidate] (4.432 ms) : 0, 4432 Remote Config [baseline] (701.518 µs) : 0, 702 Remote Config [candidate] (719.634 µs) : 0, 720 Telemetry [baseline] (15.036 ms) : 0, 15036 Telemetry [candidate] (15.056 ms) : 0, 15056 section iast BytebuddyAgent [baseline] (849.026 ms) : 0, 849026 BytebuddyAgent [candidate] (841.171 ms) : 0, 841171 GlobalTracer [baseline] (231.564 ms) : 0, 231564 GlobalTracer [candidate] (229.825 ms) : 0, 229825 IAST [baseline] (22.982 ms) : 0, 22982 IAST [candidate] (22.727 ms) : 0, 22727 AppSec [baseline] (56.215 ms) : 0, 56215 AppSec [candidate] (56.055 ms) : 0, 56055 Debugger [baseline] (4.153 ms) : 0, 4153 Debugger [candidate] (4.14 ms) : 0, 4140 Remote Config [baseline] (602.709 µs) : 0, 603 Remote Config [candidate] (598.198 µs) : 0, 598 Telemetry [baseline] (8.76 ms) : 0, 8760 Telemetry [candidate] (8.714 ms) : 0, 8714 section iast_HARDCODED_SECRET_DISABLED BytebuddyAgent [baseline] (846.287 ms) : 0, 846287 BytebuddyAgent [candidate] (856.148 ms) : 0, 856148 GlobalTracer [baseline] (230.318 ms) : 0, 230318 GlobalTracer [candidate] (232.846 ms) : 0, 232846 IAST [baseline] (22.732 ms) : 0, 22732 IAST [candidate] (23.273 ms) : 0, 23273 AppSec [baseline] (55.999 ms) : 0, 55999 AppSec [candidate] (56.881 ms) : 0, 56881 Debugger [baseline] (4.106 ms) : 0, 4106 Debugger [candidate] (4.245 ms) : 0, 4245 Remote Config [baseline] (591.443 µs) : 0, 591 Remote Config [candidate] (619.439 µs) : 0, 619 Telemetry [baseline] (8.74 ms) : 0, 8740 Telemetry [candidate] (9.043 ms) : 0, 9043 section iast_TELEMETRY_OFF BytebuddyAgent [baseline] (845.887 ms) : 0, 845887 BytebuddyAgent [candidate] (839.059 ms) : 0, 839059 GlobalTracer [baseline] (230.559 ms) : 0, 230559 GlobalTracer [candidate] (230.014 ms) : 0, 230014 IAST [baseline] (22.472 ms) : 0, 22472 IAST [candidate] (22.131 ms) : 0, 22131 AppSec [baseline] (56.084 ms) : 0, 56084 AppSec [candidate] (55.926 ms) : 0, 55926 Debugger [baseline] (4.116 ms) : 0, 4116 Debugger [candidate] (4.099 ms) : 0, 4099 Remote Config [baseline] (599.166 µs) : 0, 599 Remote Config [candidate] (582.602 µs) : 0, 583 Telemetry [baseline] (8.603 ms) : 0, 8603 Telemetry [candidate] (8.512 ms) : 0, 8512 Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~9fe9944f89, baseline=1.48.0-SNAPSHOT~295a700744 dateFormat X axisFormat %s section tracing Agent [baseline] (1.058 s) : 0, 1058488 Total [baseline] (10.478 s) : 0, 10478354 Agent [candidate] (1.059 s) : 0, 1059400 Total [candidate] (10.47 s) : 0, 10469972 section appsec Agent [baseline] (1.205 s) : 0, 1204976 Total [baseline] (10.846 s) : 0, 10845827 Agent [candidate] (1.203 s) : 0, 1202871 Total [candidate] (10.812 s) : 0, 10811873 section iast Agent [baseline] (1.187 s) : 0, 1186568 Total [baseline] (11.036 s) : 0, 11035936 Agent [candidate] (1.186 s) : 0, 1185737 Total [candidate] (11.029 s) : 0, 11029230 section profiling Agent [baseline] (1.295 s) : 0, 1295221 Total [baseline] (10.956 s) : 0, 10955829 Agent [candidate] (1.301 s) : 0, 1301028 Total [candidate] (10.915 s) : 0, 10915415
gantt title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~9fe9944f89, baseline=1.48.0-SNAPSHOT~295a700744 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (721.273 ms) : 0, 721273 BytebuddyAgent [candidate] (723.028 ms) : 0, 723028 GlobalTracer [baseline] (239.861 ms) : 0, 239861 GlobalTracer [candidate] (239.749 ms) : 0, 239749 AppSec [baseline] (54.887 ms) : 0, 54887 AppSec [candidate] (54.755 ms) : 0, 54755 Debugger [baseline] (4.405 ms) : 0, 4405 Debugger [candidate] (4.442 ms) : 0, 4442 Remote Config [baseline] (689.081 µs) : 0, 689 Remote Config [candidate] (707.079 µs) : 0, 707 Telemetry [baseline] (16.525 ms) : 0, 16525 Telemetry [candidate] (15.748 ms) : 0, 15748 section appsec BytebuddyAgent [baseline] (745.074 ms) : 0, 745074 BytebuddyAgent [candidate] (744.101 ms) : 0, 744101 GlobalTracer [baseline] (237.798 ms) : 0, 237798 GlobalTracer [candidate] (236.971 ms) : 0, 236971 IAST [baseline] (21.524 ms) : 0, 21524 IAST [candidate] (21.318 ms) : 0, 21318 AppSec [baseline] (177.08 ms) : 0, 177080 AppSec [candidate] (177.078 ms) : 0, 177078 Debugger [baseline] (4.324 ms) : 0, 4324 Debugger [candidate] (4.275 ms) : 0, 4275 Remote Config [baseline] (641.64 µs) : 0, 642 Remote Config [candidate] (643.735 µs) : 0, 644 Telemetry [baseline] (8.346 ms) : 0, 8346 Telemetry [candidate] (8.259 ms) : 0, 8259 section iast BytebuddyAgent [baseline] (843.381 ms) : 0, 843381 BytebuddyAgent [candidate] (842.097 ms) : 0, 842097 GlobalTracer [baseline] (230.371 ms) : 0, 230371 GlobalTracer [candidate] (230.448 ms) : 0, 230448 IAST [baseline] (22.664 ms) : 0, 22664 IAST [candidate] (22.665 ms) : 0, 22665 AppSec [baseline] (55.858 ms) : 0, 55858 AppSec [candidate] (56.315 ms) : 0, 56315 Debugger [baseline] (4.114 ms) : 0, 4114 Debugger [candidate] (4.115 ms) : 0, 4115 Remote Config [baseline] (594.808 µs) : 0, 595 Remote Config [candidate] (582.464 µs) : 0, 582 Telemetry [baseline] (8.766 ms) : 0, 8766 Telemetry [candidate] (8.653 ms) : 0, 8653 section profiling BytebuddyAgent [baseline] (713.483 ms) : 0, 713483 BytebuddyAgent [candidate] (718.201 ms) : 0, 718201 GlobalTracer [baseline] (360.957 ms) : 0, 360957 GlobalTracer [candidate] (361.532 ms) : 0, 361532 AppSec [baseline] (54.345 ms) : 0, 54345 AppSec [candidate] (53.635 ms) : 0, 53635 Debugger [baseline] (4.364 ms) : 0, 4364 Debugger [candidate] (4.39 ms) : 0, 4390 Remote Config [baseline] (706.418 µs) : 0, 706 Remote Config [candidate] (722.637 µs) : 0, 723 Telemetry [baseline] (9.08 ms) : 0, 9080 Telemetry [candidate] (9.056 ms) : 0, 9056 ProfilingAgent [baseline] (104.051 ms) : 0, 104051 ProfilingAgent [candidate] (105.124 ms) : 0, 105124 Profiling [baseline] (104.075 ms) : 0, 104075 Profiling [candidate] (105.15 ms) : 0, 105150 LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~9fe9944f89, baseline=1.48.0-SNAPSHOT~295a700744 dateFormat X axisFormat %s section baseline no_agent (1.356 ms) : 1337, 1375 . : milestone, 1356, appsec (1.724 ms) : 1701, 1747 . : milestone, 1724, appsec_no_iast (1.742 ms) : 1719, 1765 . : milestone, 1742, code_origins (1.701 ms) : 1675, 1727 . : milestone, 1701, iast (1.488 ms) : 1464, 1512 . : milestone, 1488, profiling (1.541 ms) : 1517, 1566 . : milestone, 1541, tracing (1.504 ms) : 1477, 1531 . : milestone, 1504, section candidate no_agent (1.36 ms) : 1341, 1380 . : milestone, 1360, appsec (1.725 ms) : 1702, 1748 . : milestone, 1725, appsec_no_iast (1.73 ms) : 1706, 1754 . : milestone, 1730, code_origins (1.686 ms) : 1660, 1713 . : milestone, 1686, iast (1.515 ms) : 1491, 1540 . : milestone, 1515, profiling (1.552 ms) : 1528, 1576 . : milestone, 1552, tracing (1.494 ms) : 1470, 1519 . : milestone, 1494,
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~9fe9944f89, baseline=1.48.0-SNAPSHOT~295a700744 dateFormat X axisFormat %s section baseline no_agent (382.213 µs) : 362, 403 . : milestone, 382, iast (506.239 µs) : 485, 528 . : milestone, 506, iast_FULL (731.801 µs) : 710, 754 . : milestone, 732, iast_GLOBAL (549.454 µs) : 528, 571 . : milestone, 549, iast_HARDCODED_SECRET_DISABLED (514.471 µs) : 492, 536 . : milestone, 514, iast_INACTIVE (461.93 µs) : 440, 484 . : milestone, 462, iast_TELEMETRY_OFF (497.487 µs) : 475, 520 . : milestone, 497, tracing (473.436 µs) : 453, 494 . : milestone, 473, section candidate no_agent (380.598 µs) : 361, 400 . : milestone, 381, iast (510.689 µs) : 489, 533 . : milestone, 511, iast_FULL (728.802 µs) : 707, 751 . : milestone, 729, iast_GLOBAL (555.31 µs) : 534, 577 . : milestone, 555, iast_HARDCODED_SECRET_DISABLED (508.371 µs) : 487, 530 . : milestone, 508, iast_INACTIVE (464.472 µs) : 443, 486 . : milestone, 464, iast_TELEMETRY_OFF (505.746 µs) : 483, 528 . : milestone, 506, tracing (458.641 µs) : 437, 480 . : milestone, 459,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~9fe9944f89, baseline=1.48.0-SNAPSHOT~295a700744 dateFormat X axisFormat %s section baseline no_agent (15.524 s) : 15524000, 15524000 . : milestone, 15524000, appsec (14.917 s) : 14917000, 14917000 . : milestone, 14917000, iast (18.817 s) : 18817000, 18817000 . : milestone, 18817000, iast_GLOBAL (18.368 s) : 18368000, 18368000 . : milestone, 18368000, profiling (15.696 s) : 15696000, 15696000 . : milestone, 15696000, tracing (14.852 s) : 14852000, 14852000 . : milestone, 14852000, section candidate no_agent (14.979 s) : 14979000, 14979000 . : milestone, 14979000, appsec (15.085 s) : 15085000, 15085000 . : milestone, 15085000, iast (19.199 s) : 19199000, 19199000 . : milestone, 19199000, iast_GLOBAL (18.169 s) : 18169000, 18169000 . : milestone, 18169000, profiling (15.176 s) : 15176000, 15176000 . : milestone, 15176000, tracing (15.188 s) : 15188000, 15188000 . : milestone, 15188000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~9fe9944f89, baseline=1.48.0-SNAPSHOT~295a700744 dateFormat X axisFormat %s section baseline no_agent (1.477 ms) : 1466, 1489 . : milestone, 1477, appsec (2.391 ms) : 2344, 2438 . : milestone, 2391, iast (2.163 ms) : 2104, 2221 . : milestone, 2163, iast_GLOBAL (2.211 ms) : 2152, 2271 . : milestone, 2211, profiling (2.014 ms) : 1967, 2061 . : milestone, 2014, tracing (1.99 ms) : 1945, 2036 . : milestone, 1990, section candidate no_agent (1.478 ms) : 1466, 1489 . : milestone, 1478, appsec (2.391 ms) : 2344, 2438 . : milestone, 2391, iast (2.171 ms) : 2111, 2230 . : milestone, 2171, iast_GLOBAL (2.205 ms) : 2145, 2264 . : milestone, 2205, profiling (2.489 ms) : 2306, 2671 . : milestone, 2489, tracing (1.986 ms) : 1941, 2032 . : milestone, 1986,
|
daniel-mohedano approved these changes Apr 7, 2025
nikita-tkachenko-datadog deleted the nikita-tkachenko/junit4-munit-double-instrumentation branch 
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Apr 11, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | org.flywaydb.flyway | plugin | misk/gradle/libs.versions.toml | gradle | minor | `11.6.0` -> `11.7.0` | | [com.squareup.okio:okio-fakefilesystem](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.10.2` -> `3.11.0` | | [com.squareup.okio:okio](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.10.2` -> `3.11.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | minor | `2.15.0` -> `2.16.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.47.3` -> `1.48.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.47.3` -> `1.48.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | --- ### Release Notes <details> <summary>square/okio (com.squareup.okio:okio-fakefilesystem)</summary> ### [`v3.11.0`](https://github.com/square/okio/blob/HEAD/CHANGELOG.md#Version-3110) *2025-04-09* - Fix: Clear the deflater's byte array reference - New: Faster implementation of `String.decodeHex()` on Kotlin/JS. - New: Declare `EXACTLY_ONCE` execution for blocks like `Closeable.use {}` and `FileSystem.read {}`. - Upgrade: \[Kotlin 2.1.20]\[kotlin\_2\_1\_20]. </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.16.0`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-2160) - \[Feat]: support `com.android.test` projects. - \[Feat]: support typesafe project accessors with opt-in. ```kotlin dependencyAnalysis { useTypesafeProjectAccessors(true) // false by default } ``` </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.48.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.1): 1.48.1 ### Components #### Tracer internal logging - 🐛 Remove print line causing unnecessary logs ([#​8687](DataDog/dd-trace-java#8687) - [@​sarahchen6](https://github.com/sarahchen6)) ### [`v1.48.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.0): 1.48.0 ### Known Bugs > \[!NOTE] > If you are experiencing issues with spamming timeout logs, please update to the [latest version](https://github.com/DataDog/dd-trace-java/releases/latest) or set [JDK_SOCKET_ENABLED](https://github.com/DataDog/dd-trace-java/blob/33fc3c9a9b7cda3beda88b8b3e5224ae2b10764a/dd-trace-api/src/main/java/datadog/trace/api/config/GeneralConfig.java#L98) to false. ### Components #### Application Security Management (IAST) - ✨ Fix vulnerability location org.jose4j.lang.HashUtil ([#​8610](DataDog/dd-trace-java#8610) - [@​jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness in oracle.ucp.util.OpaqueString ([#​8609](DataDog/dd-trace-java#8609) - [@​jandro996](https://github.com/jandro996)) - ✨ Fix weak hash false positive in oracle.security.o5logon.O5Logon ([#​8608](DataDog/dd-trace-java#8608) - [@​jandro996](https://github.com/jandro996)) - 🐛 Prevent before callsites targeting constructors in super calls ([#​8549](DataDog/dd-trace-java#8549) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Application Security Management (WAF) - ✨ Update login events public SDK to V2 ([#​8620](DataDog/dd-trace-java#8620) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Send RASP LFI capability only when AppSec is statically enabled ([#​8573](DataDog/dd-trace-java#8573) - [@​jandro996](https://github.com/jandro996)) - ✨ Improve detection of missing request end events ([#​8510](DataDog/dd-trace-java#8510) - [@​smola](https://github.com/smola)) - 🧹 Remove remote configuration for API Security sampling rate ([#​8486](DataDog/dd-trace-java#8486) - [@​smola](https://github.com/smola)) - ✨ Add setUser to user monitoring SDK ([#​8482](DataDog/dd-trace-java#8482) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add missing address for signup event ([#​8469](DataDog/dd-trace-java#8469) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Allow login events SDK to be used with appsec disabled ([#​8464](DataDog/dd-trace-java#8464) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for endpoint discovery in spring mvc ([#​8352](DataDog/dd-trace-java#8352) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ New API Security sampling algorithm ([#​8178](DataDog/dd-trace-java#8178) - [@​ValentinZakharov](https://github.com/ValentinZakharov)) #### Build & Tooling - ✨ Add buffer size customizability to JDK UDS support ([#​8629](DataDog/dd-trace-java#8629) - [@​sarahchen6](https://github.com/sarahchen6)) - ✨ Add JDK built-in support for UDS on Java 16+ ([#​8314](DataDog/dd-trace-java#8314) - [@​sarahchen6](https://github.com/sarahchen6)) #### Configuration at Runtime - 🐛 Send RASP LFI capability only when AppSec is statically enabled ([#​8573](DataDog/dd-trace-java#8573) - [@​jandro996](https://github.com/jandro996)) #### Continuous Integration Visibility - 🐛 Prevent double reporting of Scalatest events when using SBT with test forking ([#​8682](DataDog/dd-trace-java#8682) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Shutdown CI Visibility test event handlers before tracer ([#​8677](DataDog/dd-trace-java#8677) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Do not apply JUnit 4 instrumentation to MUnit runners ([#​8675](DataDog/dd-trace-java#8675), [#​8683](DataDog/dd-trace-java#8683) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Remove error log when source path resolution fails on isModified check ([#​8663](DataDog/dd-trace-java#8663) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement tests reordering for JUnit 4 ([#​8650](DataDog/dd-trace-java#8650) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Set default Attempt to Fix retries if none provided from the backend ([#​8615](DataDog/dd-trace-java#8615) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Allow to manually set PR info ([#​8566](DataDog/dd-trace-java#8566) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Test Optimization init when repo root cannot be determined ([#​8533](DataDog/dd-trace-java#8533) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add capabilities tagging ([#​8499](DataDog/dd-trace-java#8499), [#​8540](DataDog/dd-trace-java#8540) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Crash tracking - 🐛 Remove dependency on bash from crash/oome uploder scripts ([#​8652](DataDog/dd-trace-java#8652) - [@​jbachorik](https://github.com/jbachorik)) #### Data Streams Monitoring - ✨ e2e pipeline configuration when data jobs is enabled ([#​8553](DataDog/dd-trace-java#8553) - [@​kr-igor](https://github.com/kr-igor)) #### Dynamic Instrumentation - 🐛 Fix In-Product when config is empty ([#​8679](DataDog/dd-trace-java#8679) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add support for filtering shaded third-party libs ([#​8612](DataDog/dd-trace-java#8612) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add In-Product Enablement ([#​8587](DataDog/dd-trace-java#8587) - [@​jpbempel](https://github.com/jpbempel)) - ✨⚡ Reduce footprint of SourceFile tracking ([#​8524](DataDog/dd-trace-java#8524) - [@​jpbempel](https://github.com/jpbempel)) - ✨⚡ Optimize the SourceFile tracking ([#​8520](DataDog/dd-trace-java#8520) - [@​jpbempel](https://github.com/jpbempel)) #### OpenTracing - 🧹 Remove activeScope() use in OpenTracing shim ([#​8478](DataDog/dd-trace-java#8478) - [@​mcculls](https://github.com/mcculls)) #### Profiling - ✨ Add profiler env check command to AgentCLI ([#​8671](DataDog/dd-trace-java#8671) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.23.0 ([#​8668](DataDog/dd-trace-java#8668) - [@​jbachorik](https://github.com/jbachorik)) - Fix a crash related to ElfParser::loadSymbolTable ([#​191](DataDog/dd-trace-java#191)) by [@​yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#192 - Unwind String.indexOf intrinsic on AArch64 by [@​MattAlp](https://github.com/MattAlp) in DataDog/java-profiler#193 - Fix Java 24 support by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#194 - A set of fixes related to clang, aarch64 and musl pecularities of vmstructs stack unwinder by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#199 - 🐛 Remove process information from JFR recording ([#​8661](DataDog/dd-trace-java#8661) - [@​r1viollet](https://github.com/r1viollet)) - 🐛 Make TempLocationManager USER aware ([#​8605](DataDog/dd-trace-java#8605) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Extract git tags from embedded git.properties and datadog_git.properties ([#​8561](DataDog/dd-trace-java#8561) - [@​wmouchere](https://github.com/wmouchere)) #### Telemetry - 🐛 Fix appsec.rasp.error and appsec.waf.error telemetry metrics ([#​8624](DataDog/dd-trace-java#8624) - [@​jandro996](https://github.com/jandro996)) - ✨ Create metric: appsec.rasp.rule.skipped ([#​8618](DataDog/dd-trace-java#8618) - [@​jandro996](https://github.com/jandro996)) - ✨ Extract git tags from embedded git.properties and datadog_git.properties ([#​8561](DataDog/dd-trace-java#8561) - [@​wmouchere](https://github.com/wmouchere)) #### Testing - 🧹 Simplify ssi tests one-pipeline ([#​8558](DataDog/dd-trace-java#8558) - [@​robertomonteromiguel](https://github.com/robertomonteromiguel)) - ✨ Add smoke tests for java's concurrent API ([#​8438](DataDog/dd-trace-java#8438) - [@​sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - ✨ Adding Support for `TRACE_PROPAGATION_BEHAVIOR_EXTRACT` ([#​8535](DataDog/dd-trace-java#8535) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer core - 🐛 Ensure shaded helpers have unique names ([#​8559](DataDog/dd-trace-java#8559) - [@​amarziali](https://github.com/amarziali)) - ✨ Support common config sources for user-provided git info ([#​8547](DataDog/dd-trace-java#8547) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Make the default config sources more robust when a security manager is installed ([#​8544](DataDog/dd-trace-java#8544) - [@​mcculls](https://github.com/mcculls)) - ✨ Support targeting services with configurations in stable configuration file ([#​8526](DataDog/dd-trace-java#8526) - [@​mtoffl01](https://github.com/mtoffl01)) - ✨ Add new parser for `DD_TAGS` and prioritizing `DD_SERVICE` ([#​8296](DataDog/dd-trace-java#8296) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer internal logging - 🐛 Add missing debug log for the cloudPayloadTaggingServices config ([#​8600](DataDog/dd-trace-java#8600) - [@​ygree](https://github.com/ygree)) - ✨ Add the possibility to output the logs of the Java tracer in JSON ([#​8083](DataDog/dd-trace-java#8083) - [@​cecile75](https://github.com/cecile75)) #### Tracer public API - ✨ Introducing `DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED` Config ([#​8536](DataDog/dd-trace-java#8536) - [@​mhlidd](https://github.com/mhlidd)) - ✨ Config Consistency Round 2 ([#​8489](DataDog/dd-trace-java#8489) - [@​mhlidd](https://github.com/mhlidd)) ### Instrumentations #### - 🐛 Fix NPE in getMdcCopy of LoggingEventInstrumentation ([#​8599](DataDog/dd-trace-java#8599) - [@​ygree](https://github.com/ygree)) #### Apache Spark instrumentation - ✨ Instrument Runtime.exit() to finish spark application spans ([#​8572](DataDog/dd-trace-java#8572) - [@​paul-laffon-dd](https://github.com/paul-laffon-dd)) - ✨ Configure OpenLineage if present in Spark instrumentation ([#​8541](DataDog/dd-trace-java#8541) - [@​mobuchowski](https://github.com/mobuchowski)) #### Armeria Instrumentation - ✨ Support armeria grpc 1.32.3 ([#​8606](DataDog/dd-trace-java#8606) - [@​github-actions](https://github.com/github-actions)\[bot]) #### AWS DynamoDB Instrumentation - ✨ Create DynamoDB instrumentation + add span pointers for `updateItem` and `deleteItem` ([#​8490](DataDog/dd-trace-java#8490) - [@​nhulston](https://github.com/nhulston)) #### AWS SDK instrumentation - ✨ Add DynamoDB in DEFAULT_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES ([#​8595](DataDog/dd-trace-java#8595) - [@​joeyzhao2018](https://github.com/joeyzhao2018)) #### Azure Functions instrumentation - ✨ Enable tracer computed trace metrics by default for Azure Functions ([#​8518](DataDog/dd-trace-java#8518) - [@​duncanpharvey](https://github.com/duncanpharvey)) - 💡 Add azure-functions instrumentation ([#​8432](DataDog/dd-trace-java#8432) - [@​duncanpharvey](https://github.com/duncanpharvey)) #### Core Java language instrumentation - 🐛 Fix ForkJoinPool.execute() instrumentation on Java 21+ ([#​8560](DataDog/dd-trace-java#8560) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Eclipse Vert.x instrumentation - ✨ Add vertx postgresql client instrumentation ([#​8471](DataDog/dd-trace-java#8471) - [@​vandonr](https://github.com/vandonr) - thanks for the contribution!) #### Kafka instrumentation - ✨ Support and test kafka-clients 4 ([#​8581](DataDog/dd-trace-java#8581) - [@​amarziali](https://github.com/amarziali)) #### Kotlin instrumentation - ✨ Avoid disconnected traces when using Kotlin flowOn ([#​8651](DataDog/dd-trace-java#8651) - [@​mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🧹 Migrate OtelContext wrapper to new internal Context API ([#​8645](DataDog/dd-trace-java#8645) - [@​mcculls](https://github.com/mcculls)) #### Spring instrumentation - 🐛 Support CompletableFuture on spring webmvc controllers ([#​8659](DataDog/dd-trace-java#8659) - [@​amarziali](https://github.com/amarziali)) - ✨ Add support for endpoint discovery in spring mvc ([#​8352](DataDog/dd-trace-java#8352) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### WebSocket Instrumentation - ✨ Instrument Jetty websocket pojo ([#​8562](DataDog/dd-trace-java#8562) - [@​amarziali](https://github.com/amarziali)) - 💡 Instrument Java Websocket API (JSR356) ([#​8440](DataDog/dd-trace-java#8440) - [@​amarziali](https://github.com/amarziali)) #### All other instrumentations - ✨ Introduce cache for peer.hostname lookup ([#​8601](DataDog/dd-trace-java#8601) - [@​mcculls](https://github.com/mcculls)) - ✨ Support pekko http 1.1 ([#​8532](DataDog/dd-trace-java#8532) - [@​amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 331314f71acaced3adc75ea5d7e855c248d593fc
amarziali pushed a commit that referenced this pull request Apr 17, 2025
ValentinZakharov added a commit that referenced this pull request May 13, 2025
* Implemented WebSocket support for Netty 4.1 * Let propagate unhandled events and fix tests * Refactoring * Refactor netty test and fix instrumentation * Improved pipeline processing - now you can insert handler in any place * Fixed helper * Refactoring * WebSocket Server support for netty-4.0 * Missing handlers use cases for netty-4.1 * Fixed handlers for netty-4.0 * Tests for netty-4.0 * Refactoring * WebSocket Server support for netty-3.8 * Tests for netty-3.8 * Spotless * Fixed tests * Add profiler env check command to AgentCLI (#8671) * Remove dependency on bash from crash/oome uploder scripts (#8652) * Do not apply JUnit 4 instrumentation to MUnit runners (#8675) * Shutdown CI Visibility test event handlers before tracer (#8677) * Prevent double reporting of Scalatest events when using SBT with test forking (#8682) * Fix In-Product when config is empty (#8679) should not stop the product with empty config * Expand MUnit runners filter to catch munit.MUnitRunner in JUnit 4 instrumentation (#8683) * Remove unused TestEventsHandler methods (#8674) * Delete print line (#8686) * Exclude ProxyLeakTask exception from exception profiling (#8666) * Use jvmstat for JDKs 9+ programmatically (#8641) * Update test.retry_reason to use full name of the feature (#8689) * Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT (#8693) * configurable dogstatsd port * wait the client handshake * move netty ws client to interested modules * Added WebSocket tracing check --------- Co-authored-by: Andrea Marziali <andrea.marziali@datadoghq.com> Co-authored-by: Jaroslav Bachorik <jaroslav.bachorik@datadoghq.com> Co-authored-by: Nikita Tkachenko <121111529+nikita-tkachenko-datadog@users.noreply.github.com> Co-authored-by: Jean-Philippe Bempel <jean-philippe.bempel@datadoghq.com> Co-authored-by: Daniel Mohedano <daniel.mohedano@datadoghq.com> Co-authored-by: Sarah Chen <sarah.chen@datadoghq.com> Co-authored-by: Matt <matthew.alp@datadoghq.com> Co-authored-by: Laplie Anderson <randomanderson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes a bug with instrumenting MUnit test runners twice.
MUnit runner is wrapped with a
munit.internal.junitinterface.JUnitRunnerWrapper, that our JUnit 4 instrumentation was mistakenly considering a JUnit 4 runner.A test session and a test module were created for this runner.
While this does not break things, it results in an extra empty session being reported, which is confusing for the users.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]