Explosives - Improve Support for custom IED ringtones#10731
Merged
PabstMirror merged 25 commits intoacemod:masterfrom Feb 28, 2025
Merged
Explosives - Improve Support for custom IED ringtones#10731PabstMirror merged 25 commits intoacemod:masterfrom
PabstMirror merged 25 commits intoacemod:masterfrom
Conversation
rautamiekka suggested changes Feb 8, 2025
PabstMirror reviewed Feb 8, 2025
Contributor Author
| I was wondering whether it would be better to use a variable for the sounds instead of the config, or at least provide that option as well. It would make it easier to use in mission files. |
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
johnb432 reviewed Feb 11, 2025
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
PabstMirror reviewed Feb 23, 2025
PabstMirror reviewed Feb 23, 2025
PabstMirror reviewed Feb 23, 2025
PabstMirror approved these changes Feb 23, 2025
johnb432 reviewed Feb 24, 2025
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
PabstMirror approved these changes Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.