Explosives - Refactor

[johnb432]

When merged this pull request will:

• Code cleanup & optimisation.
• Fix and improve ownership transfer of explosives when a unit receives a detonator from another. If a unit has multiple detonators to give, it will only pass explosive ownership when the last one is passed to the receiving unit.
• Reverted invalid IED codes immediately stopping call, which was unintentionally introduced in Explosives - Improve Support for custom IED ringtones #10731.
• Eliminate race condition for getting IED cellphone code.
• Cache detonators.
• Check variable types in public functions.
• Remove ace_explosives_fnc_detonateExplosiveAll, as it's just a forEach loop and isn't API.
• Remove ace_explosives_fnc_dialingPhone, as it's only used in 1 instance, is relatively short and isn't API.
• Improve documentation.
• Address ACE3 Feature Requests #3594 (comment) by adding ace_explosives_defuseStart and adding missing documentation for ace_explosives_defuse and ace_explosives_explodeOnDefuse.
• Remove owned explosives upon respawn.

• Fully test all features.
  • Test cellphones.
  • Test ownership transfer when moving detonators from one container to the next.
  • Test planting explosives.
  • Test defusing.
  • Test detonators (timer, pressure, remote).

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[PabstMirror]

merged fix from #10958

[johnb432]

It's finally ready for review.

---

Not sure what to think about Remove owned explosives upon respawn.. I want explosives to be tied to their clackers, as I find it weird to magically have the ability to detonate explosives after you respawn (that is, if you have the correct clacker type of course). However, if you have your mission set up to delete corpses upon respawn, this means that the placed explosives would lose their clacker and can't be detonates, unless you defuse and place the explosives again.
Personally I find this fair in terms of realism (corpse was destroyed, therefore clacker was too), but I'm not too sure how good it is from a gameplay point of view. Any thoughts?

[LinkIsGrim]

Personally I find this fair in terms of realism (corpse was destroyed, therefore clacker was too), but I'm not too sure how good it is from a gameplay point of view. Any thoughts?

Corpse cleanup on respawn should generally take a while. For missions fast-paced enough to warrant cleaning up corpses that fast, we really wouldn't want explosives to still be tied to the player after respawn IMO.

[rautamiekka]

Personally I find this fair in terms of realism (corpse was destroyed, therefore clacker was too), but I'm not too sure how good it is from a gameplay point of view. Any thoughts?

Corpse cleanup on respawn should generally take a while. For missions fast-paced enough to warrant cleaning up corpses that fast, we really wouldn't want explosives to still be tied to the player after respawn IMO.

100% agree. Zeuses will cleanup useless corpses, though.

[rautamiekka]

Not sure what to think about Remove owned explosives upon respawn.. I want explosives to be tied to their clackers, as I find it weird to magically have the ability to detonate explosives after you respawn (that is, if you have the correct clacker type of course). However, if you have your mission set up to delete corpses upon respawn, this means that the placed explosives would lose their clacker and can't be detonates, unless you defuse and place the explosives again. Personally I find this fair in terms of realism (corpse was destroyed, therefore clacker was too), but I'm not too sure how good it is from a gameplay point of view. Any thoughts?

Yeah, having to defuse and rearm the explosives would be the best option so far.