Catch SQLException when calling JDBC API from agent #1035
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is an improvement on the previous fix #1006 that wraps all calls made by the agent to make sure that:
SQLExceptionwill mark the JDBC feature as not supported for the JDBC implementation.Checklist
I have made corresponding changes to the documentationI have updated supported-technologies.asciidocAdded an API method or config option? Document in which version this will be introducedAdded an instrumentation plugin? How did you make sure that old, non-supported versions are not instrumented by accident?Author's Checklist
Statement.getUpdateCountthat might not be supported Span isn't closed if JDBC implementation errors on the getUpdateCount method #1006Statement.getConnectionthat might return null (unlikely, but possible)Connection.getMetadatathat might return null (unlikely, but possible)Related issues