Skip to content

Conversation

@SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Feb 13, 2020

What does this PR do?

This is an improvement on the previous fix #1006 that wraps all calls made by the agent to make sure that:

  • any thrown SQLException will mark the JDBC feature as not supported for the JDBC implementation.
  • avoid to trigger excessive logging and throwing exceptions at each JDBC call

Checklist

  • My code follows the style guidelines of this project
  • I have rebased my changes on top of the latest master branch
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing [unit tests](https://github.com/elastic/apm-agent-
  • I have updated CHANGELOG.asciidoc
  • I have updated supported-technologies.asciidoc
  • Added an API method or config option? Document in which version this will be introduced
  • Added an instrumentation plugin? How did you make sure that old, non-supported versions are not instrumented by accident?

Author's Checklist

Related issues

@SylvainJuge SylvainJuge marked this pull request as ready for review February 13, 2020 18:03
@SylvainJuge SylvainJuge self-assigned this Feb 18, 2020
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test for potential performance degradation before merging

@SylvainJuge SylvainJuge removed the request for review from eyalkoren February 27, 2020 09:26
Keeping it 'as-is' is required in servlet plugin, because tests fail for an unknown reason yet.
@SylvainJuge SylvainJuge merged commit 2e9e312 into elastic:master Mar 3, 2020
@SylvainJuge SylvainJuge deleted the catch-pokemon-jdbc-exceptions branch March 3, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants