Skip to content

Conversation

@SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Apr 20, 2020

Due to many issues and unexpected side-effects of calling Statement.getUpdateCount, we decided to remove calls to this method performed by our agent.

This will partially revert work that has been done for elastic/apm#112 / #707

Here is the non-exhaustive list of issues/PR that are related to this simple (but cursed) feature:

This will be a two-step process

  • quickly remove calls to getUpdateCount from the agent
  • properly proceed to removal, and make sure that feature is still supported for Statement.executeUpdate(), for which we can capture the return value.
@SylvainJuge SylvainJuge self-assigned this Apr 20, 2020
@SylvainJuge SylvainJuge merged commit 5f3a4f9 into elastic:master Apr 20, 2020
@SylvainJuge SylvainJuge deleted the try-disable-getUpdateCount branch April 20, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants