Skip to content

Writing only in debug when failing to set JMS property #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Writing only in debug when failing to set JMS property #1862

wants to merge 1 commit into from

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Jun 15, 2021 •
edited by zube bot
Loading

No description provided.

@eyalkoren
Copy link
Contributor Author

eyalkoren commented Jun 15, 2021

This PR is done in order to demote the Failed to set JMS message property warning message to debug level altogether. However, it was done due to a report from a user that was apparently using an older version, before we already reduce logging level for MessageNotWriteableException in #1715.
So, pending on this user's feedback, we can decide whether this is a required change.
Even if not, we may use it to fix an improper logging done in #1730, where the exception is not treated as a Throwable.
@ghost
Copy link

ghost commented Jun 15, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-06-24T15:39:20.118+0000

  • Duration: 54 min 53 sec

  • Commit: ab11d22

Test stats 🧪

Test Results
Failed 0
Passed 2245
Skipped 18
Total 2263

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2245
Skipped 18
Total 2263

SylvainJuge
SylvainJuge approved these changes Jun 16, 2021
View reviewed changes
...n/apm-jms-plugin-base/src/main/java/co/elastic/apm/agent/jms/JmsMessagePropertyAccessor.java
Comment on lines +85 to +88
} catch (Exception e) {
if (logger.isDebugEnabled()) {
logger.debug(String.format("Failed to set JMS message property %s. This may indicate a real problem that " +
"can prevent from distributed tracing from working, but it may also be a valid scenario.", headerName), e);
Copy link
Member

@SylvainJuge SylvainJuge Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] We did not added a test for this case when doing this previous try/catch block with MessageNotWriteableException. It might be worth adding it this time
as it's already the 2cnd time we revisit this code.
Copy link
Contributor Author

@eyalkoren eyalkoren Jun 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we have no indication it is still a problem. Apparently, the user that reported this warning message was using an older version, so the 1.23.0 change to debug may be sufficient.
So I will close this one now and we'll fix that if indeed required.
@eyalkoren eyalkoren closed this Jun 27, 2021
@eyalkoren eyalkoren deleted the jms-quietly-catch-property-write-failures branch June 27, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java

2 participants

@eyalkoren @SylvainJuge