Skip to content

Writing only in debug when failing to set JMS property #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Writing only in debug when failing to set JMS property #1862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...pm-jms-plugin-base/src/main/java/co/elastic/apm/agent/jms/JmsMessagePropertyAccessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,11 @@ public void setHeader(String headerName, String headerValue, Message message) {
}
try {
message.setStringProperty(headerName, headerValue);
} catch (MessageNotWriteableException e) {
logger.debug("Failed to set JMS message property {} due to read-only message", headerName, e);
} catch (JMSException e) {
logger.warn("Failed to set JMS message property {}. Distributed tracing may not work.", headerName);
logger.debug("Detailed error: ", e);
} catch (Exception e) {
if (logger.isDebugEnabled()) {
logger.debug(String.format("Failed to set JMS message property %s. This may indicate a real problem that " +
"can prevent from distributed tracing from working, but it may also be a valid scenario.", headerName), e);
Comment on lines +85 to +88
Copy link
Member

@SylvainJuge SylvainJuge Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] We did not added a test for this case when doing this previous try/catch block with MessageNotWriteableException. It might be worth adding it this time
as it's already the 2cnd time we revisit this code.
Copy link
Contributor Author

@eyalkoren eyalkoren Jun 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we have no indication it is still a problem. Apparently, the user that reported this warning message was using an older version, so the 1.23.0 change to debug may be sufficient.
So I will close this one now and we'll fix that if indeed required.
}
}
}
}