Skip to content

Set service target for non-sampled ES client spans #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 15, 2023
Merged

Set service target for non-sampled ES client spans #2959

merged 3 commits into from
Jan 15, 2023

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Jan 11, 2023 •
edited
Loading

What does this PR do?

Fixes #2952

Checklist

  • This is a bugfix
@eyalkoren eyalkoren added the bug Bugs label Jan 11, 2023
@eyalkoren eyalkoren requested a review from jackshirazi January 11, 2023 13:14
jackshirazi
jackshirazi approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@jackshirazi jackshirazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the CHANGELOG entry please
@eyalkoren eyalkoren mentioned this pull request Jan 11, 2023
Closed
@ghost
Copy link

ghost commented Jan 11, 2023 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-15T07:10:59.596+0000

  • Duration: 67 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 3411
Skipped 42
Total 3453

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)
@eyalkoren eyalkoren enabled auto-merge (squash) January 15, 2023 07:11
@eyalkoren eyalkoren merged commit 1961192 into elastic:main Jan 15, 2023
@eyalkoren eyalkoren deleted the es-instrumentation-fix-non-sampled branch January 15, 2023 08:19
v1v added a commit that referenced this pull request Jan 25, 2023
@v1v
Merge remote-tracking branch 'upstream/main' into feature/use-github-…
1469de7 
…actions * upstream/main: (76 commits) Bump version.byte-buddy from 1.12.20 to 1.12.21 (#2953) Fix instrumentation for WebFlux with Spring 6.x (#2936) Fix SQS instrumentation within messaging transactions (#2979) Add test for unsampled Transaction (#2950) clarify about dropped requests for sampling in documentation (#2957) Doc add first stack trace detail (#2978) SpanBuilder.addLink is supported, so delete wrong comment (#2975) [doc] document log sending (#2929) Fix agent log sending (#2974) Bump version.aws.sdk from 2.19.8 to 2.19.18 in /apm-agent-plugins (#2973) test: synchronizing gherkin specs (#2965) Bump aws-java-sdk from 1.12.353 to 1.12.376 in /apm-agent-plugins (#2944) Fixed AgentOverheadMetricsTest flakyness (#2918) Fix AWS instrumentation destination.service.resource handling (#2947) [doc] restructure logs doc (#2916) Junit5 test with dependencies runner (#2962) Set service target for non-sampled ES client spans (#2959) Send logs via intake API (#2694) [doc] setup with docker image (#2956) Increase CI build timeout (#2955) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java bug Bugs

2 participants

@eyalkoren @jackshirazi