Junit5 test with dependencies runner #2962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| /test |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
38 tasks
SylvainJuge approved these changes Jan 12, 2023
Member
SylvainJuge left a comment
SylvainJuge left a comment There was a problem hiding this comment.
🎉 Good job! this unblocks the Junit5 migration that we aim to do for a while.
apm-agent-core/src/test/java/co/elastic/apm/agent/testutils/TestClassWithDependencyRunner.java Show resolved Hide resolved
Contributor Author
| /test |
v1v added a commit that referenced this pull request Jan 25, 2023
…actions * upstream/main: (76 commits) Bump version.byte-buddy from 1.12.20 to 1.12.21 (#2953) Fix instrumentation for WebFlux with Spring 6.x (#2936) Fix SQS instrumentation within messaging transactions (#2979) Add test for unsampled Transaction (#2950) clarify about dropped requests for sampling in documentation (#2957) Doc add first stack trace detail (#2978) SpanBuilder.addLink is supported, so delete wrong comment (#2975) [doc] document log sending (#2929) Fix agent log sending (#2974) Bump version.aws.sdk from 2.19.8 to 2.19.18 in /apm-agent-plugins (#2973) test: synchronizing gherkin specs (#2965) Bump aws-java-sdk from 1.12.353 to 1.12.376 in /apm-agent-plugins (#2944) Fixed AgentOverheadMetricsTest flakyness (#2918) Fix AWS instrumentation destination.service.resource handling (#2947) [doc] restructure logs doc (#2916) Junit5 test with dependencies runner (#2962) Set service target for non-sampled ES client spans (#2959) Send logs via intake API (#2694) [doc] setup with docker image (#2956) Increase CI build timeout (#2955) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
TestClassWithDependenciesRunnervariant which supports JUnit5 test classes.Also did a bit of refactoring and moved the runner into the existing
testutilspackage.Checklist
I have updated CHANGELOG.asciidoc