Skip to content

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 4, 2024

Resolved / Related Issues

  • Fixed crash that would occur when Git path contained an emoji
StrictFilePathMarshaler.MarshalManagedToNative (Object managedObj) /_/LibGit2Sharp/Core/FilePathMarshaler.cs, line 76 System.Text.EncoderFallbackException: Unable to translate Unicode character \\uDC83 at index 24 to specified code page 
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Feb 4, 2024
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I think this is rather an issue with LibGit2Sharp)

@yaira2 yaira2 merged commit dde05f6 into main Feb 5, 2024
@yaira2 yaira2 deleted the ya/EncoderFallbackException branch February 5, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull requests that are ready for review

3 participants