Skip to content

Fix: Fixed crash that would occur when Git path contained an emoji #14643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Fix: Fixed crash that would occur when Git path contained an emoji #14643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4b4f50
Fix: Fixed crash when Git path contained an emoji
yaira2 Feb 4, 2024
146bab3
Merge branch 'main' into ya/EncoderFallbackException
yaira2 Feb 5, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Files.App/Utils/Git/GitHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using System.Net.Http;
using System.Net.Http.Json;
using System.Net.Sockets;
using System.Text;
using System.Text.Json;
using System.Text.RegularExpressions;

Expand Down Expand Up @@ -96,7 +97,7 @@ public static void TryDispose()
? path
: GetGitRepositoryPath(PathNormalization.GetParentDir(path), root);
}
catch (LibGit2SharpException ex)
catch (Exception ex) when (ex is LibGit2SharpException or EncoderFallbackException)
{
_logger.LogWarning(ex.Message);

Expand Down