Skip to content

feat: support tencent cos custom domain#30193

Merged
fatelei merged 2 commits intolanggenius:mainfrom
fatelei:issue-29001
Dec 29, 2025
Merged

feat: support tencent cos custom domain#30193
fatelei merged 2 commits intolanggenius:mainfrom
fatelei:issue-29001

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Dec 26, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #29001

support tencent cos custom domain

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Dec 26, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the Tencent Cloud Object Storage (COS) integration by enabling the use of custom domains. This change provides greater flexibility and control over how COS resources are accessed, allowing for more tailored and potentially optimized storage solutions within the application. It ensures that the system can adapt to various deployment scenarios where custom domain mapping for cloud storage is a requirement.

Highlights

  • Tencent COS Custom Domain Support: Introduced a new configuration option, TENCENT_COS_CUSTOM_DOMAIN, to allow users to specify a custom domain for Tencent Cloud Object Storage.
  • Flexible COS Configuration: The TencentCosStorage class now dynamically configures the COS client, prioritizing the custom domain if provided, and falling back to the traditional region-based setup otherwise.
  • Enhanced Test Coverage: New unit tests have been added to thoroughly validate the TencentCosStorage initialization logic for both custom domain and region-based configurations.
  • Environment Variable Update: The .env.example file has been updated to include the new TENCENT_COS_CUSTOM_DOMAIN variable, guiding users on how to configure this feature.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for using a custom domain with Tencent Cloud COS, which is a great feature enhancement. The implementation is straightforward and includes corresponding configuration updates and new unit tests to verify the logic for both custom domain and region-based setups. I've suggested a small refactoring to reduce code duplication in the TencentCosStorage initialization, which will improve maintainability. Overall, this is a solid contribution.

QuantumGhost
QuantumGhost previously approved these changes Dec 29, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 29, 2025
@fatelei fatelei merged commit 2c919ef into langgenius:main Dec 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

2 participants