Skip to content

feat: add decryption decorators for password and code fields in webapp#30704

Merged
douxc merged 1 commit intomainfrom
fix/webapp-login-cred-encode
Jan 8, 2026
Merged

feat: add decryption decorators for password and code fields in webapp#30704
douxc merged 1 commit intomainfrom
fix/webapp-login-cred-encode

Conversation

@GareArc
Copy link
Contributor

@GareArc GareArc commented Jan 7, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
Copilot AI review requested due to automatic review settings January 7, 2026 11:00
@GareArc GareArc requested a review from QuantumGhost as a code owner January 7, 2026 11:00
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 7, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @GareArc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements new decryption decorators for sensitive user input fields within the web application's authentication flows. Specifically, it applies a password decryption decorator to the standard login API and a code decryption decorator to the email code login API, ensuring that these fields are automatically decrypted before being handled by the respective authentication logic. This enhancement aims to bolster the security posture of user authentication by centralizing and automating the decryption process for critical credentials.

Highlights

  • New Decryption Decorators: Introduced decrypt_password_field and decrypt_code_field decorators to handle the decryption of sensitive input fields.
  • Enhanced Login Security: Applied the new decryption decorators to the post methods of LoginApi and EmailCodeLoginApi to automatically decrypt password and code fields, respectively, before processing.
  • Centralized Decryption Logic: This change centralizes the decryption logic for sensitive authentication data, improving maintainability and security.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the 💪 enhancement New feature or request label Jan 7, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds decryption decorators to the password and code fields for web application login endpoints. The changes are correct and achieve the intended goal. However, I've pointed out an architectural concern regarding dependencies between web and console controllers, which could be improved for better modularity and long-term maintainability.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds field decryption decorators to web application login endpoints to handle Base64-encoded password and verification code fields from the frontend. This brings the webapp login endpoints in line with the existing console login implementation.

Key Changes

  • Imported decrypt_password_field and decrypt_code_field decorators from controllers.console.wraps
  • Applied @decrypt_password_field decorator to LoginApi.post() method
  • Applied @decrypt_code_field decorator to EmailCodeLoginApi.post() method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 8, 2026
@douxc douxc merged commit adaf0e3 into main Jan 8, 2026
21 checks passed
@douxc douxc deleted the fix/webapp-login-cred-encode branch January 8, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

3 participants