Skip to content

REF: use can_use_libjoin more consistently, docstring for it #54664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2023
Merged

REF: use can_use_libjoin more consistently, docstring for it #54664

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f6efa0
REF: fix can_use_libjoin check
jbrockmendel Aug 15, 2023
c9a5d53
DOC: docstring for can_use_libjoin
jbrockmendel Aug 16, 2023
f65f29c
Make can_use_libjoin checks more-correct
jbrockmendel Aug 16, 2023
2719f9b
mypy fixup
jbrockmendel Aug 20, 2023
e6cadfe
Fix exception message
jbrockmendel Aug 20, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix exception message
  • Loading branch information
@jbrockmendel
jbrockmendel committed Aug 21, 2023
commit e6cadfeabcbb4114f03f0fccb25e61da61aec044
2 changes: 1 addition & 1 deletion pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5195,7 +5195,7 @@ def _get_join_target(self) -> np.ndarray:
# copies.
target = self._get_engine_target()
if not isinstance(target, np.ndarray):
raise ValueError("_can_use_libjoin should raise in this case.")
raise ValueError("_can_use_libjoin should return False.")
return target

def _from_join_target(self, result: np.ndarray) -> ArrayLike:
Expand Down